Bug 783657 - (fiwalk) Review Request: fiwalk - Batch analysis of a disk image
Review Request: fiwalk - Batch analysis of a disk image
Status: CLOSED WONTFIX
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Michal Ambroz
Fedora Extras Quality Assurance
:
Depends On:
Blocks: FE-SECLAB
  Show dependency treegraph
 
Reported: 2012-01-21 09:54 EST by Nicolas Chauvet (kwizart)
Modified: 2012-07-04 04:30 EDT (History)
5 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2012-07-04 04:30:20 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)

  None (edit)
Description Nicolas Chauvet (kwizart) 2012-01-21 09:54:55 EST
Spec URL: http://kwizart.fedorapeople.org/review/fiwalk.spec
SRPM URL: http://kwizart.fedorapeople.org/review/fiwalk-0.6.16-1.fc17.src.rpm
Description: Batch analysis of a disk image
Comment 1 Volker Fröhlich 2012-01-21 19:17:04 EST
Correct these permissions in the prep section:

fiwalk-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/fiwalk-0.6.16/src/fiwalk.cpp
fiwalk-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/fiwalk-0.6.16/src/base64.h
fiwalk-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/fiwalk-0.6.16/src/base64.cpp

COPYING states Public Domain.

I think the description could be better. Maybe you can make up something together with http://afflib.org/software/fiwalk?

Consider to install the example Python scripts as documentation. Though I wonder about where the Python module is.


(The stuff I wrote on defattr and EPEL on the aimage review also applies here.)
Comment 2 Nicolas Chauvet (kwizart) 2012-01-23 18:21:50 EST
Spec URL: http://kwizart.fedorapeople.org/review/fiwalk.spec
SRPM URL: http://kwizart.fedorapeople.org/review/fiwalk-0.6.16-2.fc17.src.rpm
Description: Batch analysis of a disk image

Changelog:
- Update description
- Fix spurious exec permission
- Correct license field to Public Domain
- Install python examples in doc

Thx for the reviews
Comment 3 Michal Ambroz 2012-06-25 21:28:01 EDT
Hello, 
I will take review of this package.
Michal Ambroz
Comment 4 Nicolas Chauvet (kwizart) 2012-07-04 04:30:20 EDT
Hi,

Thx for the attempt to review, but this package will be merged in the next version of sleuthkit (already in fedora).

Note You need to log in before you can comment on or make changes to this bug.