Spec URL: http://www.geofrogger.net/review/cptutils.spec SRPM URL: http://www.geofrogger.net/review/cptutils-1.41-1.fc16.src.rpm Description: The cptutils package contains a number of utilities for the manipulation of color gradients; mainly for translating between different formats. Formats supported include ggr (GIMP gradient), cpt (GMT color palette table), avl (Arcview Legend), lut (xmedcon), svg, and version 3 of the grd format. The cptutils package was written to aid the construction of the cpt archive cpt-city http://soliton.vm.bytemark.co.uk/pub/cpt-city where thousands of gradients can be downloaded. http://koji.fedoraproject.org/koji/taskinfo?taskID=3720229 rpmlint: cptutils.src: W: spelling-error %description -l en_US ggr -> gr, gar, mgr cptutils.src: W: spelling-error %description -l en_US cpt -> pct, cot, ct cptutils.src: W: spelling-error %description -l en_US avl -> val, av, lav cptutils.src: W: spelling-error %description -l en_US lut -> loot, ult, lit cptutils.src: W: spelling-error %description -l en_US xmedcon -> consumed cptutils.src: W: spelling-error %description -l en_US svg -> avg, sag, VG cptutils.src: W: spelling-error %description -l en_US grd -> gr, rd, grid cptutils.x86_64: W: spelling-error %description -l en_US ggr -> gr, gar, mgr cptutils.x86_64: W: spelling-error %description -l en_US cpt -> pct, cot, ct cptutils.x86_64: W: spelling-error %description -l en_US avl -> val, av, lav cptutils.x86_64: W: spelling-error %description -l en_US lut -> loot, ult, lit cptutils.x86_64: W: spelling-error %description -l en_US xmedcon -> consumed cptutils.x86_64: W: spelling-error %description -l en_US svg -> avg, sag, VG cptutils.x86_64: W: spelling-error %description -l en_US grd -> gr, rd, grid cptutils.x86_64: E: incorrect-fsf-address /usr/share/doc/cptutils-1.41/COPYING I'll take care of that wrong address in COPYING.
The author responded with a new release that most likely resolves all issues mentioned in the spec file. I'll package that as soon as possible.
Spec URL: http://www.geofrogger.net/review/cptutils.spec SRPM URL: http://www.geofrogger.net/review/cptutils-1.42-1.fc16.src.rpm [makerpm@desktop cptutils]$ rpmlint /home/makerpm/rpmbuild/SRPMS/cptutils-1.42-1.fc16.src.rpm /home/makerpm/rpmbuild/RPMS/x86_64/cptutils-*1.42-1.fc16.x86_64.rpm cptutils.src: W: spelling-error %description -l en_US ggr -> gr, gar, mgr cptutils.src: W: spelling-error %description -l en_US cpt -> pct, cot, ct cptutils.src: W: spelling-error %description -l en_US avl -> val, av, lav cptutils.src: W: spelling-error %description -l en_US lut -> loot, ult, lit cptutils.src: W: spelling-error %description -l en_US xmedcon -> consumed cptutils.src: W: spelling-error %description -l en_US svg -> avg, sag, VG cptutils.src: W: spelling-error %description -l en_US grd -> gr, rd, grid cptutils.x86_64: W: spelling-error %description -l en_US ggr -> gr, gar, mgr cptutils.x86_64: W: spelling-error %description -l en_US cpt -> pct, cot, ct cptutils.x86_64: W: spelling-error %description -l en_US avl -> val, av, lav cptutils.x86_64: W: spelling-error %description -l en_US lut -> loot, ult, lit cptutils.x86_64: W: spelling-error %description -l en_US xmedcon -> consumed cptutils.x86_64: W: spelling-error %description -l en_US svg -> avg, sag, VG cptutils.x86_64: W: spelling-error %description -l en_US grd -> gr, rd, grid
I'll take this review.
Is the flex BR really necessary? I don't see flex being invoked during the build. +: OK -: must be fixed =: should be fixed (at your discretion) N: not applicable MUST: [+] rpmlint output: cptutils.x86_64: W: spelling-error %description -l en_US ggr -> gr, gar, mgr cptutils.x86_64: W: spelling-error %description -l en_US cpt -> pct, cot, ct cptutils.x86_64: W: spelling-error %description -l en_US avl -> val, av, lav cptutils.x86_64: W: spelling-error %description -l en_US lut -> loot, ult, lit cptutils.x86_64: W: spelling-error %description -l en_US xmedcon -> consumed cptutils.x86_64: W: spelling-error %description -l en_US svg -> avg, sag, VG cptutils.x86_64: W: spelling-error %description -l en_US grd -> gr, rd, grid 1 packages and 1 specfiles checked; 0 errors, 7 warnings. Those are all innocuous. [+] follows package naming guidelines [+] spec file base name matches package name [+] package meets the packaging guidelines [+] package uses a Fedora approved license [+] license field matches the actual license [+] license file is included in %doc [+] spec file is in American English [+] spec file is legible [+] sources match upstream: md5sum is 46a1e1a22e75c84514b6515f3ccad1d8 for both [+] package builds on at least one primary arch (tried x86_64) [N] appropriate use of ExcludeArch [+] all build requirements in BuildRequires: [N] spec file handles locales properly [N] ldconfig in %post and %postun [+] no bundled copies of system libraries [+] no relocatable packages [+] package owns all directories that it creates [+] no files listed twice in %files [+] proper permissions on files [+] consistent use of macros [+] code or permissible content [N] large documentation in -doc [+] no runtime dependencies in %doc [N] header files in -devel [N] static libraries in -static [N] .so in -devel [N] -devel requires main package [+] package contains no libtool archives [N] package contains a desktop file, uses desktop-file-install [+] package does not own files/dirs owned by other packages [+] all filenames in UTF-8 SHOULD: [N] query upstream for license text [N] description and summary contain available translations [+] package builds in mock: tried fedora-rawhide-i386 [+] package builds on all supported arches: tried i386 and x86_64 [+] package functions as described: light testing only [+] sane scriptlets [N] subpackages require the main package [N] placement of pkgconfig files [N] file dependencies versus package dependencies [N] package contains man pages for binaries/scripts If the flex BR isn't necessary, please remove it. Otherwise, this package looks great. APPROVED.
Flex is not necessary, I'll remove it. Thanks for the review!
New Package SCM Request ======================= Package Name: cptutils Short Description: Utilities to manipulate and translate color gradients Owners: volter Branches: f15 f16 f17 InitialCC:
Git done (by process-git-requests).
cptutils-1.42-2.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/cptutils-1.42-2.fc16
cptutils-1.42-2.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/cptutils-1.42-2.fc17
cptutils-1.42-2.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/cptutils-1.42-2.fc15
cptutils-1.42-2.fc17 has been pushed to the Fedora 17 testing repository.
cptutils-1.42-2.fc15 has been pushed to the Fedora 15 stable repository.
cptutils-1.42-2.fc16 has been pushed to the Fedora 16 stable repository.
cptutils-1.42-2.fc17 has been pushed to the Fedora 17 stable repository.