Bug 783849 - Review Request: ktoblzcheck - A library to check account numbers and bank codes of German banks
Summary: Review Request: ktoblzcheck - A library to check account numbers and bank cod...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: 16
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Brian Pepple
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-01-22 21:13 UTC by Johannes Schmid
Modified: 2012-03-08 14:40 UTC (History)
3 users (show)

Fixed In Version: goffice08-0.8.17-4.fc17
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-03-08 06:03:24 UTC
Type: ---
Embargoed:
bdpepple: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Johannes Schmid 2012-01-22 21:13:55 UTC
Description of problem:

The ktoblzcheck package (http://sourceforge.net/projects/ktoblzcheck/) is a super simply tool to verify german bank and account numbers. It has virtually no dependency and it enables gnucash to show the correct bank names for the numbers.

The aqbanking developer highly recommend to use it.

Comment 1 Bill Nottingham 2012-01-23 17:30:05 UTC
I'm not necessarily against it, but it's not something I'd use or have the ability to check with a live accounts - it would be one of those 'build and punt all functional bugs to upstream' sort of packages. Want to help maintain/comaintain it?

Comment 2 Johannes Schmid 2012-01-23 21:34:10 UTC
I can certainly test it but I doubt I will have time to maintain yet another package. I maintain far too much upstream stuff.

Comment 3 Bill Nottingham 2012-01-31 22:11:39 UTC
Spec URL: http://notting.fedorapeople.org/review/ktoblzcheck.spec
SRPM URL: http://notting.fedorapeople.org/review/ktoblzcheck-1.37-1.src.rpm

Description: KtoBLZCheck is a library to check account numbers and bank codes of
German banks. Both a library for other programs as well as a short
command-line tool is available. It is possible to check pairs of
account numbers and bank codes (BLZ) of German banks, and to map bank
codes (BLZ) to the clear-text name and location of the bank.

Comment 4 Brian Pepple 2012-02-28 22:52:41 UTC
Good:
* Source URL is canonical
* Upstream source tarball verified
* Package name conforms to the Fedora Naming Guidelines
* Group Tag is from the official list
* All paths begin with macros
* All directories are owned by this or other packages
* All necessary BuildRequires listed.
* Builds fine in mock.
* Doesn't contain any .la libtool archives.

Minor Non-blockers:
* I believe the clean section & the %defattr in the files section are not necessary anymore.
* rpmlint errors:
ktoblzcheck.x86_64: W: file-not-utf8 /usr/share/doc/ktoblzcheck-1.37/NEWS
ktoblzcheck.x86_64: E: incorrect-fsf-address /usr/share/doc/ktoblzcheck-1.37/COPYING
ktoblzcheck.x86_64: W: file-not-utf8 /usr/share/doc/ktoblzcheck-1.37/ChangeLog

+1 Package Approved. Those rpmlint errors can be corrected when you import the package.

Comment 5 Bill Nottingham 2012-02-29 19:17:44 UTC
New Package SCM Request
=======================
Package Name: ktoblzcheck
Short Description: A library to check account numbers and bank codes of German banks
Owners: notting
Branches: f17 f16 el6
InitialCC:

Comment 6 Gwyn Ciesla 2012-02-29 19:22:02 UTC
Git done (by process-git-requests).

Comment 7 Bill Nottingham 2012-02-29 20:32:17 UTC
Built, will go out in rawhide tomorrow, and in earlier releases with gnucash-2.4.10 update.

Comment 8 Fedora Update System 2012-02-29 21:38:06 UTC
goffice08-0.8.17-4.fc17, gnucash-2.4.10-1.fc17, ktoblzcheck-1.37-1.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/gnucash-2.4.10-1.fc17,goffice08-0.8.17-4.fc17,ktoblzcheck-1.37-1.fc17

Comment 9 Fedora Update System 2012-03-02 00:59:35 UTC
Package goffice08-0.8.17-4.fc17, gnucash-2.4.10-1.fc17, ktoblzcheck-1.37-1.fc17:
* should fix your issue,
* was pushed to the Fedora 17 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing goffice08-0.8.17-4.fc17 gnucash-2.4.10-1.fc17 ktoblzcheck-1.37-1.fc17'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2012-2822/gnucash-2.4.10-1.fc17,goffice08-0.8.17-4.fc17,ktoblzcheck-1.37-1.fc17
then log in and leave karma (feedback).

Comment 10 Fedora Update System 2012-03-08 06:03:24 UTC
goffice08-0.8.17-4.fc17, gnucash-2.4.10-1.fc17, ktoblzcheck-1.37-1.fc17 has been pushed to the Fedora 17 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 11 Johannes Schmid 2012-03-08 14:40:27 UTC
Thanks!


Note You need to log in before you can comment on or make changes to this bug.