Created attachment 556885 [details]
Orange's build.log on Fedora 17

Today, I discovered that %filter_setup is at fault here.

If I remove the following lines from the SPEC file:
%{?filter_setup:
%filter_provides_in %{python_sitearch}/%{name}/.*\.so$
%filter_from_requires /liborange.so/d
%filter_setup
}

rpmbuild doesn't report any warnings anymore.

Thus, I'm changing the component to redhat-rpm-config.

If it helps, I can provide the build logs and SRPMS of the software I'm packaging.

I met this issue too, under up-to-update F17.

Created attachment 614038 [details]
Patch that fixes the issue

The $FILE argument has to be in double quotes so it works for file names with spaces. The double quotes in the __find_provides and __find_requires commands were replaced with single quotes for proper shell quotes nesting.

I notice that other filter macros which are used in __find_provides and __find_requires currently use single quotes.  Will those need to be changed as well?

For instance:

%filter_provides_in(P) %{expand: \
%global __filter_prov_cmd %{?__filter_prov_cmd} %{__grep} -v %{-P} '%*' | \
}

(In reply to comment #5)
> I notice that other filter macros which are used in __find_provides and
> __find_requires currently use single quotes.  Will those need to be changed
> as well?

To my understanding, they don't need to be changed.

For example, in my SPEC file I have the following filter set up:
%{?filter_setup:
%filter_provides_in %{python_sitearch}/%{name}/.*\.so$
%filter_from_requires /liborange.so/d
%filter_setup
}

During the building of the RPM, these macros become the following commands:
Finding  Provides: /bin/sh -c ' /usr/bin/grep -v  '/usr/lib64/python2.7/site-packages/orange/.*\.so$' | while read FILE; do /usr/lib/rpm/rpmdeps -P "${FILE}"; done | /bin/sort -u '
Finding  Requires: /bin/sh -c '  while read FILE; do /usr/lib/rpm/rpmdeps -R "${FILE}"; done | /bin/sort -u  | /usr/bin/sed -e '/liborange.so/d''

So, '%*' in %global __filter_prov_cmd %{?__filter_prov_cmd} %{__grep} -v %{-P} '%*' | \ gets expanded to '/usr/lib64/python2.7/site-packages/orange/.*\.so$' and the nested single quotes appear to work ok.

Toshio, thank you for fixing the long standing bugs in redhat-rpm-config!
Will you also include the fix for this bug in the update?

I may end up pushing it only to rawhide but my intention is to get it into a package so we can start testing that it works.

Thanks for your expansion!  I think it shows a bug.  If the pattern given to filter_provides_in ends up having spaces then grep (and sed in the filter_from_requires) will end up with multiple arguments.

If you have time to test that corner case, it would help me out.  If not, I can get around to it after a deadline I have for a different project for Tuesday next week.

(In reply to comment #7)
> I may end up pushing it only to rawhide but my intention is to get it into a
> package so we can start testing that it works.

OK, makes sense.
 
> Thanks for your expansion!  I think it shows a bug.  If the pattern given to
> filter_provides_in ends up having spaces then grep (and sed in the
> filter_from_requires) will end up with multiple arguments.
 
> If you have time to test that corner case, it would help me out.  If not, I
> can get around to it after a deadline I have for a different project for
> Tuesday next week.

I tried testing that corner case. I changed my filter setup to:
%{?filter_setup:
%filter_provides_in %{python_sitearch}/test a space/%{name}/.*\.so$
%filter_from_requires /lib with space.so/d
%filter_setup
}

During rpmbuild, this got translated to (excerpt from build log):
Finding  Provides: /bin/sh -c ' /usr/bin/grep -v  '/usr/lib64/python2.7/site-packages/test a space/orange-test/.*\.so$' | while read FILE; do /usr/lib/rpm/rpmdeps -P "${FILE}"; done | /bin/sort -u '
/usr/bin/sed: -e expression #1, char 4: unterminated address regex
Finding  Requires: /bin/sh -c '  while read FILE; do /usr/lib/rpm/rpmdeps -R "${FILE}"; done | /bin/sort -u  | /usr/bin/sed -e '/lib with space.so/d''

So, the grep command looks fine, while the sed command produces an error.
I'm really a shell or sed expert to know what would be the correct solution for this.

Does this fix it for you?


# actually set up the filtering bits 
%filter_setup %{expand: \
%global _use_internal_dependency_generator 0 \
%global __deploop() while read FILE; do echo "${FILE}" | /usr/lib/rpm/rpmdeps -%{1}; done | /bin/sort -u \
%global __find_provides /bin/sh -c "%{?__filter_prov_cmd} %{__deploop P} %{?__filter_from_prov}" \
%global __find_requires /bin/sh -c "%{?__filter_req_cmd}  %{__deploop R} %{?__filter_from_req}" \
}

Note that all quotes are double quotes.  Panu suggested it in: https://bugzilla.redhat.com/show_bug.cgi?id=873847  which I believe is a duplicate of this.

*** Bug 873847 has been marked as a duplicate of this bug. ***

(In reply to comment #9)
> Does this fix it for you?

Yes, it does.

> # actually set up the filtering bits 
> %filter_setup %{expand: \
> %global _use_internal_dependency_generator 0 \
> %global __deploop() while read FILE; do echo "${FILE}" |
> /usr/lib/rpm/rpmdeps -%{1}; done | /bin/sort -u \
> %global __find_provides /bin/sh -c "%{?__filter_prov_cmd} %{__deploop P}
> %{?__filter_from_prov}" \
> %global __find_requires /bin/sh -c "%{?__filter_req_cmd}  %{__deploop R}
> %{?__filter_from_req}" \
> }

I've used the above code and repeated the experiment from comment #8. Not it expands to this:
Finding  Provides: /bin/sh -c " /usr/bin/grep -v  '/usr/lib64/python2.7/site-packages/test a space/orange-test/.*\.so$' | while read FILE; do echo "${FILE}" | /usr/lib/rpm/rpmdeps -P; done | /bin/sort -u "
Finding  Requires: /bin/sh -c "  while read FILE; do echo "${FILE}" | /usr/lib/rpm/rpmdeps -R; done | /bin/sort -u  | /usr/bin/sed -e '/lib with space.so/d'"
Provides: corn.so()(64bit) orangene.so()(64bit) orangeom.so()(64bit) orange.so()(64bit) statc.so()(64bit)

I didn't see any errors.

This is now built for rawhide:

http://koji.fedoraproject.org/koji/buildinfo?buildID=365437

I may push it back to F18 as well.  I want to see if we can fix #872737 first, though... that would be the last of the low hanging fruit that's currently opened against redhat-rpm-config

redhat-rpm-config-9.1.0-37.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/redhat-rpm-config-9.1.0-37.fc18