Hide Forgot
SPEC: http://bkabrda.fedorapeople.org/pkgs/vim-nerdtree/vim-nerdtree.spec SRPM: http://bkabrda.fedorapeople.org/pkgs/vim-nerdtree/vim-nerdtree-4.2.0-1.fc16.src.rpm Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=3728222 The NERD tree allows you to explore your filesystem and to open files and directories. It presents the filesystem to you in the form of a tree which you manipulate with the keyboard and/or mouse. It also allows you to perform simple filesystem operations.
I'll take this review, since I like to use NERDtree.
* Should use vim-common - It seems that instead of requiring vim and vim-filesystem, you should use vim-common package. * Do not own the directories owned by vim-filesystem. - According to FPG: Directory ownership is a little more complex than file ownership. Packages must own all directories they put files in, except for: any directories owned by the filesystem, man, or other explicitly created -filesystem packages - You should own just content of the following directories, not the directories itself: %{vimfiles_root}/doc %{vimfiles_root}/plugin %{vimfiles_root}/syntax * You shoud preserve the file timestamps - Please use cp -a or install command * Package naming - I am unsure it the package name is really correct. Could you please check with upstream if they are going to stick with "nerdtree" from now?
(In reply to comment #2) > * Should use vim-common > - It seems that instead of requiring vim and vim-filesystem, you should use > vim-common package. > Done. > * Do not own the directories owned by vim-filesystem. > - According to FPG: > > Directory ownership is a little more complex than file ownership. Packages > must own all directories they put files in, except for: > > any directories owned by the filesystem, man, or other explicitly created > -filesystem packages > > - You should own just content of the following directories, not the > directories itself: > > %{vimfiles_root}/doc > %{vimfiles_root}/plugin > %{vimfiles_root}/syntax > Done. > > * You shoud preserve the file timestamps > - Please use cp -a or install command > Huh, thought i did that... Done. > * Package naming > - I am unsure it the package name is really correct. Could you please check > with upstream if they are going to stick with "nerdtree" from now? Will do. I will put the new SPEC/SRPM as soon as I will deal with this naming issue. Thank you!
The author says that there is no official name and vim-nerdtree is fine [1], so I'm sticking with that. Here are the updated files: SPEC: http://bkabrda.fedorapeople.org/pkgs/vim-nerdtree/vim-nerdtree.spec SRPM: http://bkabrda.fedorapeople.org/pkgs/vim-nerdtree/vim-nerdtree-4.2.0-2.fc16.src.rpm [1] https://github.com/scrooloose/nerdtree/issues/121#issuecomment-3650623
Well, not exactly answer I'd expected, but hey .... Otherwise I have no other objections => APPROVED
Thank you for your request! New Package SCM Request ======================= Package Name: vim-nerdtree Short Description: A tree explorer plugin that owns your momma Owners: bkabrda Branches: f16 InitialCC:
Git done (by process-git-requests).
vim-nerdtree-4.2.0-3.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/vim-nerdtree-4.2.0-3.fc16
vim-nerdtree-4.2.0-3.fc16 has been pushed to the Fedora 16 testing repository.
vim-nerdtree-4.2.0-3.fc16 has been pushed to the Fedora 16 stable repository.