Spec URL: http://www.matthias-runge.de/fedora/python-django-debug-toolbar.spec SRPM URL: http://www.matthias-runge.de/fedora/python-django-debug-toolbar-0.9.3-1.fc16.src.rpm Description: The Django Debug Toolbar is a configurable set of panels that display various debug information about the current request/response and when clicked, display more details about the panel's content. Currently, the following panels have been written and are working: - Django version - Request timer - A list of settings in settings.py - Common HTTP headers - GET/POST/cookie/session variable display - Templates and context used, and their template paths - SQL queries including time to execute and links to EXPLAIN each query - List of signals, their args and receivers - Logging output via Python's built-in logging, or via the logbook module koji scratchbuild: http://koji.fedoraproject.org/koji/taskinfo?taskID=3728505 I am aware of some spellig warnings as well of hidden-file-or-dir warnings. This doesn't affect package function. check-section not functional: https://github.com/django-debug-toolbar/django-debug-toolbar/issues/256 This is a nice-to-have, but not really required for building. I'm planning to activate checks, once upstream fixed the issue. According to https://bugzilla.redhat.com/show_bug.cgi?id=736776 this package should be named python-django-debug-toolbar instead of django-debug-toolbar
Please post rpmlint output on all RPM packages and SPEC files.
rpmlint follows, one SRPM, one RPM, one SPEC file [mrunge@mrungexp SPECS]$ rpmlint ./python-django-debug-toolbar.spec ../SRPMS/python-django-debug-toolbar-0.9.3-1.fc16.src.rpm ../RPMS/noarch/python-django-debug-toolbar-0.9.3-1.fc16.noarch.rpm python-django-debug-toolbar.src: W: spelling-error %description -l en_US py -> pt, p, y python-django-debug-toolbar.src: W: spelling-error %description -l en_US args -> rags, gars, ares python-django-debug-toolbar.noarch: W: spelling-error %description -l en_US py -> pt, p, y python-django-debug-toolbar.noarch: W: spelling-error %description -l en_US args -> rags, gars, ares python-django-debug-toolbar.noarch: W: hidden-file-or-dir /usr/lib/python2.7/site-packages/debug_toolbar/templates/debug_toolbar/panels/._profiling.html python-django-debug-toolbar.noarch: W: hidden-file-or-dir /usr/lib/python2.7/site-packages/debug_toolbar/media/debug_toolbar/css/._toolbar.css python-django-debug-toolbar.noarch: W: hidden-file-or-dir /usr/lib/python2.7/site-packages/debug_toolbar/templates/debug_toolbar/panels/._sql.html python-django-debug-toolbar.noarch: W: hidden-file-or-dir /usr/lib/python2.7/site-packages/debug_toolbar/media/debug_toolbar/js/._jquery.cookie.js python-django-debug-toolbar.noarch: W: hidden-file-or-dir /usr/lib/python2.7/site-packages/debug_toolbar/templates/debug_toolbar/panels/._sql_explain.html python-django-debug-toolbar.noarch: W: hidden-file-or-dir /usr/lib/python2.7/site-packages/debug_toolbar/templates/debug_toolbar/panels/._sql_profile.html python-django-debug-toolbar.noarch: W: hidden-file-or-dir /usr/lib/python2.7/site-packages/debug_toolbar/templates/debug_toolbar/panels/._sql_select.html 2 packages and 1 specfiles checked; 0 errors, 11 warnings.
Taking this package for a review.
Package Review ============== Key: - = N/A x = Pass ! = Fail ? = Not evaluated ==== Generic ==== [x]: MUST Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: MUST Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: MUST All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: MUST Buildroot is not present Note: Unless packager wants to package for EPEL5 this is fine [x]: MUST Package contains no bundled libraries. [x]: MUST Changelog in prescribed format. [x]: MUST Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: Clean would be needed if support for EPEL is required [x]: MUST Sources contain only permissible code or content. [x]: MUST Each %files section contains %defattr if rpm < 4.4 Note: Note: defattr macros not found. They would be needed for EPEL5 [x]: MUST Macros in Summary, %description expandable at SRPM build time. [x]: MUST Package requires other packages for directories it uses. [x]: MUST Package uses nothing in %doc for runtime. [x]: MUST Package is not known to require ExcludeArch. [x]: MUST Permissions on files are set properly. [x]: MUST Package does not contain duplicates in %files. [x]: MUST Spec file lacks Packager, Vendor, PreReq tags. [x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf would be needed if support for EPEL5 is required [x]: MUST If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: MUST License field in the package spec file matches the actual license. [x]: MUST Package consistently uses macros (instead of hard-coded directory names). [x]: MUST Package meets the Packaging Guidelines. [x]: MUST Package is named according to the Package Naming Guidelines. [x]: MUST Package does not generates any conflict. [x]: MUST Package obeys FHS, except libexecdir and /usr/target. [x]: MUST Package must own all directories that it creates. [x]: MUST Package does not own files or directories owned by other packages. [x]: MUST Package installs properly. [x]: MUST Requires correct, justified where necessary. [!]: MUST Rpmlint output is silent. rpmlint python-django-debug-toolbar-0.9.3-1.fc17.noarch.rpm python-django-debug-toolbar.noarch: W: spelling-error %description -l en_US py -> pt, p, y python-django-debug-toolbar.noarch: W: spelling-error %description -l en_US args -> rags, gars, ares python-django-debug-toolbar.noarch: W: hidden-file-or-dir /usr/lib/python2.7/site-packages/debug_toolbar/templates/debug_toolbar/panels/._profiling.html python-django-debug-toolbar.noarch: W: hidden-file-or-dir /usr/lib/python2.7/site-packages/debug_toolbar/media/debug_toolbar/css/._toolbar.css python-django-debug-toolbar.noarch: W: hidden-file-or-dir /usr/lib/python2.7/site-packages/debug_toolbar/templates/debug_toolbar/panels/._sql.html python-django-debug-toolbar.noarch: W: hidden-file-or-dir /usr/lib/python2.7/site-packages/debug_toolbar/media/debug_toolbar/js/._jquery.cookie.js python-django-debug-toolbar.noarch: W: hidden-file-or-dir /usr/lib/python2.7/site-packages/debug_toolbar/templates/debug_toolbar/panels/._sql_explain.html python-django-debug-toolbar.noarch: W: hidden-file-or-dir /usr/lib/python2.7/site-packages/debug_toolbar/templates/debug_toolbar/panels/._sql_profile.html python-django-debug-toolbar.noarch: W: hidden-file-or-dir /usr/lib/python2.7/site-packages/debug_toolbar/templates/debug_toolbar/panels/._sql_select.html 1 packages and 0 specfiles checked; 0 errors, 9 warnings. rpmlint python-django-debug-toolbar-0.9.3-1.fc17.src.rpm python-django-debug-toolbar.src: W: spelling-error %description -l en_US py -> pt, p, y python-django-debug-toolbar.src: W: spelling-error %description -l en_US args -> rags, gars, ares 1 packages and 0 specfiles checked; 0 errors, 2 warnings. [x]: MUST Sources used to build the package match the upstream source, as provided in the spec URL. /home/karel/devel/hatchery/784239/django-debug-toolbar-0.9.3.tar.gz : MD5SUM this package : c11870fb6f206c6dc2efd9a134fd672c MD5SUM upstream package : c11870fb6f206c6dc2efd9a134fd672c [x]: MUST Spec file is legible and written in American English. [x]: MUST Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: MUST Package contains a SysV-style init script if in need of one. [x]: MUST File names are valid UTF-8. [x]: SHOULD Reviewer should test that the package builds in mock. [x]: SHOULD If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: SHOULD Dist tag is present. [x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q --requires). [x]: SHOULD Package functions as described. [x]: SHOULD Package does not include license text files separate from upstream. [x]: SHOULD SourceX is a working URL. [x]: SHOULD Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: SHOULD Package should compile and build into binary rpms on all supported architectures. [!]: SHOULD %check is present and all tests pass. Tests fail but it seems to be a bug in upstream tarball. [x]: SHOULD Packages should try to preserve timestamps of original installed files. [x]: SHOULD Spec use %global instead of %define. Issues: [!]: MUST Rpmlint output is silent. rpmlint python-django-debug-toolbar-0.9.3-1.fc17.noarch.rpm python-django-debug-toolbar.noarch: W: spelling-error %description -l en_US py -> pt, p, y python-django-debug-toolbar.noarch: W: spelling-error %description -l en_US args -> rags, gars, ares python-django-debug-toolbar.noarch: W: hidden-file-or-dir /usr/lib/python2.7/site-packages/debug_toolbar/templates/debug_toolbar/panels/._profiling.html python-django-debug-toolbar.noarch: W: hidden-file-or-dir /usr/lib/python2.7/site-packages/debug_toolbar/media/debug_toolbar/css/._toolbar.css python-django-debug-toolbar.noarch: W: hidden-file-or-dir /usr/lib/python2.7/site-packages/debug_toolbar/templates/debug_toolbar/panels/._sql.html python-django-debug-toolbar.noarch: W: hidden-file-or-dir /usr/lib/python2.7/site-packages/debug_toolbar/media/debug_toolbar/js/._jquery.cookie.js python-django-debug-toolbar.noarch: W: hidden-file-or-dir /usr/lib/python2.7/site-packages/debug_toolbar/templates/debug_toolbar/panels/._sql_explain.html python-django-debug-toolbar.noarch: W: hidden-file-or-dir /usr/lib/python2.7/site-packages/debug_toolbar/templates/debug_toolbar/panels/._sql_profile.html python-django-debug-toolbar.noarch: W: hidden-file-or-dir /usr/lib/python2.7/site-packages/debug_toolbar/templates/debug_toolbar/panels/._sql_select.html 1 packages and 0 specfiles checked; 0 errors, 9 warnings. The hidden files seem to be metadata for a Mac OS X text editor. It would be better if they would be removed in the spec file and not distributed in Fedora RPMs: rm -f debug_toolbar/templates/debug_toolbar/panels/.*html rm -f debug_toolbar/media/debug_toolbar/{css/.*css,js/.*js} Upstream maintainer can be informed about him storing such a files in the tarballs. However, this seems to be low priority. rpmlint python-django-debug-toolbar-0.9.3-1.fc17.src.rpm python-django-debug-toolbar.src: W: spelling-error %description -l en_US py -> pt, p, y python-django-debug-toolbar.src: W: spelling-error %description -l en_US args -> rags, gars, ares 1 packages and 0 specfiles checked; 0 errors, 2 warnings. [!]: SHOULD %check is present and all tests pass. Tests fail but it seems to be a bug in upstream tarball. Generated by fedora-review 0.1.2 APPROVED
Karel, thank you for the review. New Package SCM Request ======================= Package Name: python-django-debug-toolbar Short Description: Configurable set of panels that display various debug information Owners: mrunge Branches: f16
Git done (by process-git-requests).
python-django-debug-toolbar-0.9.3-1.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/python-django-debug-toolbar-0.9.3-1.fc16
python-django-debug-toolbar-0.9.3-1.fc16 has been pushed to the Fedora 16 testing repository.
python-django-debug-toolbar-0.9.3-1.fc16 has been pushed to the Fedora 16 stable repository.
Package Change Request ====================== Package Name: python-django-debug-toolbar New Branches: el6 Owners: mrunge