Bug 784426 - multiple GET parameters are lost when creating Request using Request.from_request factory
Summary: multiple GET parameters are lost when creating Request using Request.from_req...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: python-oauth2
Version: rawhide
Hardware: Unspecified
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Tom "spot" Callaway
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-01-24 21:39 UTC by Jason Connor
Modified: 2014-03-31 01:39 UTC (History)
2 users (show)

Fixed In Version: python-oauth2-1.5.211-1.fc17
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-02-25 08:26:36 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
proposed patch to fix issue (1.45 KB, patch)
2012-01-24 21:41 UTC, Jason Connor
no flags Details | Diff

Description Jason Connor 2012-01-24 21:39:46 UTC
User-Agent:       Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/535.7 (KHTML, like Gecko) Chrome/16.0.912.75 Safari/535.7

oauth2 has been patched in many ways to handle multiple GET parameters with the same key, however, the Request.from_request factory still does not correctly handle this.

Reproducible: Always

Steps to Reproduce:
1.use Request.from_request factory
2.pass in query_string with multiple GET parameters with the same key
3.notice that Request instance [key] only has the first value in it
Actual Results:  
only first value is stored in Request instance for parameters with the same key

Expected Results:  
Request instance should store a list of all values

patch provided

Comment 1 Jason Connor 2012-01-24 21:41:08 UTC
Created attachment 557320 [details]
proposed patch to fix issue

should be submitted upstream

Comment 2 Tom "spot" Callaway 2012-02-16 15:55:27 UTC
The upstream seems to be idle/asleep/dead (again) on python-oauth2. There are quite a few pending pull requests (including several different fixes for handling this exact issue). That said, your fix seems simple enough, so I'll carry it in Fedora. I've also submitted it as a pull request to upstream, but I have low confidence it will be merged anytime soon.

Comment 3 Fedora Update System 2012-02-16 16:40:19 UTC
python-oauth2-1.5.211-1.fc15 has been submitted as an update for Fedora 15.
https://admin.fedoraproject.org/updates/python-oauth2-1.5.211-1.fc15

Comment 4 Fedora Update System 2012-02-16 16:40:27 UTC
python-oauth2-1.5.211-1.fc16 has been submitted as an update for Fedora 16.
https://admin.fedoraproject.org/updates/python-oauth2-1.5.211-1.fc16

Comment 5 Fedora Update System 2012-02-16 16:40:36 UTC
python-oauth2-1.5.211-1.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/python-oauth2-1.5.211-1.fc17

Comment 6 Fedora Update System 2012-02-16 19:26:47 UTC
Package python-oauth2-1.5.211-1.fc17:
* should fix your issue,
* was pushed to the Fedora 17 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing python-oauth2-1.5.211-1.fc17'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2012-1831/python-oauth2-1.5.211-1.fc17
then log in and leave karma (feedback).

Comment 7 Fedora Update System 2012-02-25 08:26:36 UTC
python-oauth2-1.5.211-1.fc15 has been pushed to the Fedora 15 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 8 Fedora Update System 2012-02-25 08:40:58 UTC
python-oauth2-1.5.211-1.fc16 has been pushed to the Fedora 16 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 9 Fedora Update System 2012-02-28 11:02:51 UTC
python-oauth2-1.5.211-1.fc17 has been pushed to the Fedora 17 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.