Spec URL: http://mef.fedorapeople.org/packages/jabref/spin.spec SRPM URL: http://mef.fedorapeople.org/packages/jabref/spin-1.5-1.fc16.src.rpm Description: Spin is a small library that concentrates on offering a powerful solution to build non-freezing Swing applications. Spin enforces good application design by separating the GUI and non-visual components through interfaces. If it is used wisely in an application framework, the GUI programmers will never have to think about threads again.
Updated package: - Remove clean section, install unversioned javadocs - Fix line endings in license file http://mef.fedorapeople.org/packages/jabref/spin-1.5-2.fc16.src.rpm
Minor changes: - Remove defattr from files section - Add license to javadoc subpackage http://mef.fedorapeople.org/packages/jabref/spin-1.5-3.fc16.src.rpm
Updates and clean-up: - Clean up pom.xml patch - Remove dos2unix build requirement - Ensure that it builds with Java 1.6.0+ Spec URL: http://mef.fedorapeople.org/packages/jabref/spin.spec SRPM URL: http://mef.fedorapeople.org/packages/jabref/spin-1.5-4.fc17.src.rpm
Package Review ============== Key: - = N/A x = Pass ! = Fail ? = Not evaluated ==== Generic ==== [x]: MUST Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: MUST Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: MUST %build honors applicable compiler flags or justifies otherwise. [x]: MUST All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: MUST Buildroot is not present Note: Unless packager wants to package for EPEL5 this is fine [!]: MUST Package contains no bundled libraries. [x]: MUST Changelog in prescribed format. [x]: MUST Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: Clean would be needed if support for EPEL is required [x]: MUST Sources contain only permissible code or content. [x]: MUST Each %files section contains %defattr if rpm < 4.4 Note: Note: defattr macros not found. They would be needed for EPEL5 [x]: MUST Macros in Summary, %description expandable at SRPM build time. [x]: MUST Package requires other packages for directories it uses. [x]: MUST Package uses nothing in %doc for runtime. [x]: MUST Package is not known to require ExcludeArch. [x]: MUST Permissions on files are set properly. [x]: MUST Package does not contain duplicates in %files. [x]: MUST Spec file lacks Packager, Vendor, PreReq tags. [!]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf is only needed if supporting EPEL5 [-]: MUST Large documentation files are in a -doc subpackage, if required. [x]: MUST If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: MUST License field in the package spec file matches the actual license. [x]: MUST License file installed when any subpackage combination is installed. [x]: MUST Package consistently uses macros (instead of hard-coded directory names). [x]: MUST Package is named according to the Package Naming Guidelines. [x]: MUST Package does not generate any conflict. [x]: MUST Package obeys FHS, except libexecdir and /usr/target. [x]: MUST Package must own all directories that it creates. [x]: MUST Package does not own files or directories owned by other packages. [x]: MUST Package installs properly. [x]: MUST Requires correct, justified where necessary. [!]: MUST Rpmlint output is silent. rpmlint spin-javadoc-1.5-4.fc18.noarch.rpm spin-javadoc.noarch: E: incorrect-fsf-address /usr/share/doc/spin-javadoc-1.5/license.txt 1 packages and 0 specfiles checked; 1 errors, 0 warnings. rpmlint spin-1.5-4.fc18.noarch.rpm spin.noarch: E: explicit-lib-dependency cglib spin.noarch: E: incorrect-fsf-address /usr/share/doc/spin-1.5/license.txt 1 packages and 0 specfiles checked; 2 errors, 0 warnings. rpmlint spin-1.5-4.fc18.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. [x]: MUST Sources used to build the package match the upstream source, as provided in the spec URL. /home/tradej/reviews/784594/spin-1.5-all.zip : MD5SUM this package : b8d6d7fa1ebaf1a2a52d7a8ec9e14319 MD5SUM upstream package : b8d6d7fa1ebaf1a2a52d7a8ec9e14319 [x]: MUST Spec file is legible and written in American English. [x]: MUST Spec file name must match the spec package %{name}, in the format %{name}.spec. [-]: MUST Package contains a SysV-style init script if in need of one. [x]: MUST File names are valid UTF-8. [-]: MUST Useful -debuginfo package or justification otherwise. [x]: SHOULD Reviewer should test that the package builds in mock. [-]: SHOULD If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: SHOULD Dist tag is present. [x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q --requires). [x]: SHOULD Package functions as described. [x]: SHOULD Latest version is packaged. [x]: SHOULD Package does not include license text files separate from upstream. [x]: SHOULD Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: SHOULD SourceX / PatchY prefixed with %{name}. [x]: SHOULD SourceX is a working URL. [-]: SHOULD Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: SHOULD Package should compile and build into binary rpms on all supported architectures. [-]: SHOULD %check is present and all tests pass. [x]: SHOULD Packages should try to preserve timestamps of original installed files. [x]: SHOULD Spec use %global instead of %define. ==== Java ==== [!]: MUST If source tarball includes bundled jar/class files these need to be removed prior to building [x]: MUST Packages have proper BuildRequires/Requires on jpackage-utils [x]: MUST Fully versioned dependency in subpackages, if present. [x]: MUST Javadoc documentation files are generated and included in -javadoc subpackage [x]: MUST Javadoc subpackages have Requires: jpackage-utils [x]: MUST Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink) [x]: SHOULD Package has BuildArch: noarch (if possible) [x]: SHOULD Package uses upstream build method (ant/maven/etc.) ==== Maven ==== [x]: MUST Pom files have correct add_maven_depmap call Note: Some add_maven_depmap calls found. Please check if they are correct [x]: MUST Old add_to_maven_depmap macro is not being used [x]: MUST Packages DOES NOT have Requires(post) and Requires(postun) on jpackage-utils for %update_maven_depmap macro [-]: MUST If package contains pom.xml files install it (including depmaps) even when building with ant [x]: MUST Package DOES NOT use %update_maven_depmap in %post/%postun [x]: MUST Packages use %{_mavenpomdir} instead of %{_datadir}/maven2/poms *** ISSUES *** [!]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf is only needed if supporting EPEL5 >>>> Please, remove this line [!]: MUST Rpmlint output is silent. >>>> Please, file a patch upstream to fix the FSF address >>>> Ignore the dependency error rpmlint spin-javadoc-1.5-4.fc18.noarch.rpm spin-javadoc.noarch: E: incorrect-fsf-address /usr/share/doc/spin-javadoc-1.5/license.txt 1 packages and 0 specfiles checked; 1 errors, 0 warnings. rpmlint spin-1.5-4.fc18.noarch.rpm spin.noarch: E: explicit-lib-dependency cglib spin.noarch: E: incorrect-fsf-address /usr/share/doc/spin-1.5/license.txt 1 packages and 0 specfiles checked; 2 errors, 0 warnings. rpmlint spin-1.5-4.fc18.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. See: http://fedoraproject.org/wiki/Packaging/Guidelines#rpmlint [!]: MUST If source tarball includes bundled jar/class files these need to be removed prior to building [!]: MUST Package contains no bundled libraries. >>>> Please, delete ./lib in %prep Generated by fedora-review 0.1.3 External plugins: *** NOT APPROVED ***
Updated: - Remove pre-built jar files before building - Don't clean buildroot before compiling - Include most recent version of the LGPL Spec URL: http://mef.fedorapeople.org/packages/jabref/spin.spec SRPM URL: http://mef.fedorapeople.org/packages/jabref/spin-1.5-5.fc17.src.rpm
The inclusion of an external license file is not acceptable, I am sorry. This mail: http://osdir.com/ml/fedora-legal-list/2011-08/msg00004.html states that other than filing a bug upstream, no action is required. Therefore, please remove the inclusion. Thank you. Other than that, it's fine.
Done! Spec URL: http://mef.fedorapeople.org/packages/jabref/spin.spec SRPM URL: http://mef.fedorapeople.org/packages/jabref/spin-1.5-6.fc17.src.rpm
Very well then. *** APPROVED ***
New Package SCM Request ======================= Package Name: spin Short Description: A transparent threading solution for non-freezing Swing applications Owners: mef Branches: f17
Git done (by process-git-requests).
spin-1.5-6.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/spin-1.5-6.fc17
spin-1.5-6.fc17 has been pushed to the Fedora 17 testing repository.
spin-1.5-6.fc17 has been pushed to the Fedora 17 stable repository.