Bug 78480 - less than optimal source code
Summary: less than optimal source code
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Red Hat Linux
Classification: Retired
Component: xcdroast
Version: 8.0
Hardware: All
OS: Linux
low
low
Target Milestone: ---
Assignee: Harald Hoyer
QA Contact: Jay Turner
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2002-11-24 10:47 UTC by d.binderman
Modified: 2015-01-08 00:01 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2003-01-09 12:50:25 UTC


Attachments (Terms of Use)

Description d.binderman 2002-11-24 10:47:07 UTC
Description of Problem:

Hello there,

I just tried to compile package xcdroast-0.98a9-18 from Redhat 8.0.

Here are some of the compiler messages.

init.c:280: warning: `return' with no value, in function returning non-void

Here is a patch which fixes the messages.

*** ./init.c.old	2002-11-06 14:33:04.000000000 +0000
--- ./init.c	2002-11-06 14:36:48.000000000 +0000
***************
*** 277,285 ****
  	/* file does exist? */
  	if (stat(file,&buf) == 0) {
  		if (!(buf.st_mode & S_ISGID)) {
- 			return;
  			g_warning("Installation problem? No set-gid bit on %s\n", file);
  			dodebug(1,"Warning: No set-gid bit on %s\n", file);
  		}
  
  		return buf.st_gid;
--- 277,285 ----
  	/* file does exist? */
  	if (stat(file,&buf) == 0) {
  		if (!(buf.st_mode & S_ISGID)) {
  			g_warning("Installation problem? No set-gid bit on %s\n", file);
  			dodebug(1,"Warning: No set-gid bit on %s\n", file);
+ 			return (gid_t) 0;
  		}
  
  		return buf.st_gid;


Version-Release number of selected component (if applicable):


How Reproducible:


Steps to Reproduce:
1. 
2. 
3. 

Actual Results:


Expected Results:


Additional Information:

Comment 1 Harald Hoyer 2003-01-09 12:50:25 UTC
fixed


Note You need to log in before you can comment on or make changes to this bug.