Hide Forgot
SPEC: http://bkabrda.fedorapeople.org/pkgs/openstack-compute/rubygem-openstack-compute.spec SRPM: http://bkabrda.fedorapeople.org/pkgs/openstack-compute/rubygem-openstack-compute-1.1.5-1.fc16.src.rpm Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=3734637 Ruby Openstack Compute binding for the v1.0 OSAPI. Currently supports both v1.0 and v2.0 (keystone) auth.
I'll take it for a review.
* Version in patch name is questionable - If the patch is not accepted by upstream for next release, you will need either to rename the patch or remove the %{version} macro anyway, so I would suggest to not use macro in this case * The test suite should not be carried by resulting gem - Although I appreciate that you are executing test suite, I suggest its unpacking just in %check section, which prevents its inclusion in resulting package. %check tar xzvf %{SOURCE1} -C .%{geminstdir} * MiniTest instead of TestUnit - Have you considered using Minitest, which is now default in Ruby, instead of test-unit? * rpmlint - Please fix following rpmlint error: rubygem-openstack-compute.noarch: E: non-executable-script \ /usr/share/gems/gems/openstack-compute-1.1.5/lib/openstack/compute.rb \ 0664L /usr/bin/env
(In reply to comment #2) > * Version in patch name is questionable > - If the patch is not accepted by upstream for next release, you will need > either to rename the patch or remove the %{version} macro anyway, > so I would suggest to not use macro in this case > True, done. > * The test suite should not be carried by resulting gem > - Although I appreciate that you are executing test suite, I suggest its > unpacking just in %check section, which prevents its inclusion in > resulting package. > > %check > tar xzvf %{SOURCE1} -C .%{geminstdir} > Done. > * MiniTest instead of TestUnit > - Have you considered using Minitest, which is now default in Ruby, instead > of > test-unit? > Yes, tests work the same way with minitest, so I switched to it. > * rpmlint > - Please fix following rpmlint error: > > rubygem-openstack-compute.noarch: E: non-executable-script \ > /usr/share/gems/gems/openstack-compute-1.1.5/lib/openstack/compute.rb \ > 0664L /usr/bin/env Fixed. SPEC: http://bkabrda.fedorapeople.org/pkgs/openstack-compute/rubygem-openstack-compute.spec SRPM: http://bkabrda.fedorapeople.org/pkgs/openstack-compute/rubygem-openstack-compute-1.1.5-2.fc16.src.rpm Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=3738691
I have no other objections => APPROVED
Thank you for your review! New Package SCM Request ======================= Package Name: rubygem-openstack-compute Short Description: OpenStack Compute Ruby API Owners: bkabrda Branches: InitialCC:
Git done (by process-git-requests).