Bug 784951 - Review Request: ktp-contact-list - Telepathy contact list application
Summary: Review Request: ktp-contact-list - Telepathy contact list application
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: nucleo
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 784945
Blocks: kde-reviews kde-telepathy-0.3
TreeView+ depends on / blocked
 
Reported: 2012-01-26 18:56 UTC by Rex Dieter
Modified: 2012-02-10 22:11 UTC (History)
4 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2012-02-10 22:11:25 UTC
Type: ---
Embargoed:
alekcejk: fedora-review+
gwync: fedora-cvs+

Attachments (Terms of Use)

Description Rex Dieter 2012-01-26 18:56:29 UTC 
Spec URL: http://rdieter.fedorapeople.org/rpms/telepathy-kde/ktp-contact-list.spec
SRPM URL: http://rdieter.fedorapeople.org/rpms/telepathy-kde/ktp-contact-list-0.3.0-1.fc16.src.rpm
Description: Telepathy contact list application
Comment 1 nucleo 2012-02-07 16:22:46 UTC 
name: ok
summary: ok
license: ok
handling locale files: ok
Obsoletes/Provides: ok
desktop-file-install: ok
Icon Cache: ok

rpmlint output: 
ktp-contact-list.i686: E: script-without-shebang /usr/share/applications/kde4/ktp-contactlist.desktop
ktp-contact-list.i686: W: no-manual-page-for-binary ktp-contactlist
3 packages and 0 specfiles checked; 1 errors, 1 warnings.

There is not real script so error can be ignored.
Comment 2 nucleo 2012-02-07 16:27:11 UTC 
Please remove unneeded BuildRequires: telepathy-qt4-devel
And replace "buildRequires" with "BuildRequires" (of cause not blocker).

So, Approved.
Comment 3 Rex Dieter 2012-02-09 18:49:44 UTC 
New Package SCM Request
=======================
Package Name: ktp-contact-list
Short Description: Telepathy contact list application
Owners: jreznik rdieter
Branches: f16
Comment 4 Gwyn Ciesla 2012-02-09 18:57:34 UTC 
Git done (by process-git-requests).

Added f17.
Comment 5 Rex Dieter 2012-02-10 22:11:25 UTC 
imported
Note You need to log in before you can comment on or make changes to this bug.