Hide Forgot
Description of problem: Conductor does not use a redhat shadowman fav.ico. As part of the official Red Hat branding, I would expect to see a shadowman fav.ico Version-Release number of selected component (if applicable): * aeolus-all-0.8.0-13.el6.src.rpm * aeolus-conductor-0.8.0-13.el6.src.rpm * aeolus-configure-2.5.0-9.el6.src.rpm * rubygem-aeolus-cli-0.3.0-6.el6.src.rpm * rubygem-aeolus-image-0.3.0-5.el6.src.rpm Steps to Reproduce: 1. Install aeolus-conductor-$version_above 2. Run aeolus-configure 3. Load aeolus website Actual results: * Observe there is no fav.ico specified Expected results: * Expected to see a redhat branded fav.iso Additional info:
Patch created, using favicon.ico found within conductor repository: https://fedorahosted.org/pipermail/aeolus-devel/2012-February/008560.html
Patch submitted - let me know if you think the favicon.ico should be updated to be RedHat specific instead of the default deltacloud ico: commit f99dfdb0ea11befef86884ecdb3e7bf2facb585f BZ 785196 added favicon.ico
(In reply to comment #2) > Patch submitted - let me know if you think the favicon.ico should be updated to > be RedHat specific instead of the default deltacloud ico: Hi Tzu-Mainn, thanks for the update. Yes, I'd expect it to be a Red Hat branded favicon when included in the Red Hat product CloudForms. The upsteam aeolus project can use whatever upstream branded is desired. Should we moved this back to ASSIGNED until a Red Hat branded icon is available?
Let me just take care of it quickly - if I understand correctly, the red hat-specific favicon change should only go in the 1.0-product branch, correct?
(In reply to comment #4) > Let me just take care of it quickly - if I understand correctly, the red > hat-specific favicon change should only go in the 1.0-product branch, correct? Hrmm, I'm probably not the best to answer that ... pulling in morazi for guidance.
f99dfdb in aeolus-conductor-0.8.0-19, not setting this to ON_QA based on previous comments.
Moving back to assigned, the deltacloud favicon.ico included in aeolus-conductor-0.8.0-19 does not resolve the reported issue.
Updated patch, created off of 1.0-product: http://post-office.corp.redhat.com/mailman/private/deltacloud-internal/2012-February/msg00037.html
Pushed to 1.0-product: commit c51cc8a152b1a5b91b88fffde729267453f7da8c BZ 785196 updated favicon link commit 965a4db923221a9091f74333f7c51907cacccfcb BZ 785196 added system-logos dependency; link to /etc/favicon.png on install
Created attachment 560129 [details] fav_ico
rpm -qa|grep aeolus aeolus-conductor-doc-0.8.0-23.el6.noarch aeolus-configure-2.5.0-12.el6.noarch aeolus-conductor-daemons-0.8.0-23.el6.noarch rubygem-aeolus-image-0.3.0-7.el6.noarch rubygem-aeolus-cli-0.3.0-8.el6.noarch aeolus-conductor-0.8.0-23.el6.noarch aeolus-all-0.8.0-23.el6.noarch
ack.. looks good
(In reply to comment #11) > Created attachment 560129 [details] > fav_ico To clarify, the attachment used to VERIFY this bug is *not* a favicon. For clarification on what a favicon is, please refer to https://en.wikipedia.org/wiki/Favicon To properly verify this fix, you must inspect the favicon used after installing and configuring aeolus. The package provides the following favicon files ... > # rpm -qpl aeolus-conductor-0.8.0-23.el6.noarch.rpm | grep favicon > /usr/share/aeolus-conductor/public/favicon.ico > /usr/share/aeolus-conductor/public/images/favicon.png The first file above (favicon.ico) is an icon file picturing the deltacloud logo. This is acceptable for upstream, but I suspect not the correct behavior. Should upstream use the aeolus logo, or the deltacloud logo. I'll raise this as a different issue. The second file (favicon.png) is a symlink to /etc/favicon.png. Depending on the system you install this package on (Fedora vs RHEL), your favicon should match the product under test. RHEL == Red Hat logo (aka shadowman) Fedora == Fedora logo Lastly, why ship two favicon files in aeolus? It makes things more confusing. I'd recommend including, and using, a *single* favicon file in aeolus-conductor (regardless of whether the package is built for upstream or downstream use). Hopefully, the proper favicon (with a Red Hat shadowman logo) is presented when accessing conductor through a web-browser. I'm moving this back to ON_QA. Shveta, can you please verify that the favicon used represents the Red Hat (shadowman) logo?
/usr/share/aeolus-conductor/public/favicon.ico /usr/share/aeolus-conductor/public/images/favicon.png are present . /etc/favicon.png is also there . Since i installed it on RHEL i see the Redhat shadowman in login page as well as in the header after logging in
Created attachment 560959 [details] ss I noticed all the files are there.. but the icon in the browser is *not* displayed.. /usr/share/aeolus-conductor/public/favicon.ico /usr/share/aeolus-conductor/public/images/favicon.png fails..
I think I forgot to push a commit into 1.0-product - it's pushed now: commit d848455041988f8319e940552bb25ab7b42a2eda BZ 785196 updated favicon link
d848455 in aeolus-conductor-0.8.0-26
Does not work in aeolus-conductor-0.8.0-28.el6.noarch The HTML includes the following link ... <link href='/images/favicon.png' rel='shortcut icon'> Accessing the URL referenced about results in a 404. You need to make the URL look like this ... <link href='/conductor/images/favicon.png' rel='shortcut icon'>
Pushed fix to 1.0-product: commit eb69ab96c4372edeb161f4df029f791fc6a21155 BZ 785196 fixed favicon link
eb69ab9 in aeolus-conductor-0.8.0-29
Created attachment 564926 [details] icon rpm -qa|grep aeolus aeolus-conductor-daemons-0.8.0-33.el6.noarch aeolus-configure-2.5.0-14.el6.noarch rubygem-aeolus-image-0.3.0-8.el6.noarch aeolus-conductor-0.8.0-33.el6.noarch rubygem-aeolus-cli-0.3.0-9.el6.noarch aeolus-conductor-doc-0.8.0-33.el6.noarch aeolus-all-0.8.0-33.el6.noarch
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. http://rhn.redhat.com/errata/RHEA-2012-0583.html