Spec URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Vfs.spec SRPM URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Vfs-1.0.8-1.fc16.src.rpm Description: This package provides a Virtual File System API
Updated Spec URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Vfs.spec SRPM URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Vfs-1.0.9-1.fc16.src.rpm
I am not an official package reviewer, but here are some comments I have for this package: *** It would help readability to group your Build* and Requires* statements together instead of mixing them with each other and your Provides and Conflicts statements *** Your BuildRequires should be BuildRequires: php-pear(PEAR) >= 1.7.0 instead of BuildRequires: php-pear >= 1:1.4.9-1.2 (this would match what you have in bug 785606 and satisfy this package's package.xml dependency) *** Per package.xml requirements, please add: Requires: php-common >= 5.2.0 *** phpci results: For completeness, you may wish to require the virtual packages (and to prevent any future packaging issues due to PHP package changes) "php-date", "php-ftp", and "php-pcre". "php-posix" is also optional, but may provide a better end-user experience if required. *** All locale files should be tagged with "%lang(xx)" *** Up to you, but package.xml lists the following optional packages if you choose to require: - php-pear(pear.horde.org/Horde_Auth) < 2.0.0 - php-pear(pear.horde.org/Horde_Core) < 2.0.0 - php-pear(pear.horde.org/Horde_Db) < 2.0.0 - php-pear(pear.horde.org/Horde_Kolab_Session) < 2.0.0 - php-pear(pear.horde.org/Horde_Mime) < 2.0.0 - php-pear(pear.horde.org/Horde_Perms) < 2.0.0 - php-pecl(ssh2) >= 0.10 (if you do choose to require these packages, please update this ticket's "Depends On")
Also, please remove "rm -rf $RPM_BUILD_ROOT" from the %install section (see http://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag) -- I'm assuming no EPEL 5 build because your other php-horde-* packages do not.
I have updated and submitted this one. *** This bug has been marked as a duplicate of bug 909706 ***