Spec URL: http://hguemar.fedorapeople.org/review/python-setproctitle.spec SRPM URL: http://hguemar.fedorapeople.org/review/python-setproctitle-1.1.3-1.fc16.src.rpm Description: Python module allowing a process to change its title as displayed by system tool such as ps and top. It's useful in multi-process systems, allowing to identify tasks each forked process is busy with. This technique has been used by PostgreSQL and OpenSSH. It's based on PostgreSQL implementation which has proven to be portable. scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3745003 rpmlint: $ rpmlint -iv python-setproctitle-1.1.3-1.fc17.src.rpm python-setproctitle.src: I: checking python-setproctitle.src: W: spelling-error %description -l en_US ps -> PS, pa, pd The value of this tag appears to be misspelled. Please double-check. python-setproctitle.src: W: spelling-error %description -l en_US multiprocess -> multiprocessor, multiprocessing The value of this tag appears to be misspelled. Please double-check. python-setproctitle.src: I: checking-url http://pypi.python.org/pypi/setproctitle (timeout 10 seconds) python-setproctitle.src: I: checking-url http://pypi.python.org/packages/source/s/setproctitle/setproctitle-1.1.3.tar.gz (timeout 10 seconds) 1 packages and 0 specfiles checked; 0 errors, 2 warnings. $ rpmlint -iv python-setproctitle-1.1.3-1.fc17.x86_64.rpm python-setproctitle.x86_64: I: checking python-setproctitle.x86_64: W: spelling-error %description -l en_US ps -> PS, pa, pd The value of this tag appears to be misspelled. Please double-check. python-setproctitle.x86_64: W: spelling-error %description -l en_US multiprocess -> multiprocessor, multiprocessing The value of this tag appears to be misspelled. Please double-check. python-setproctitle.x86_64: I: checking-url http://pypi.python.org/pypi/setproctitle (timeout 10 seconds) 1 packages and 0 specfiles checked; 0 errors, 2 warnings. $ rpmlint -iv python3-setproctitle-1.1.3-1.fc17.x86_64.rpm python3-setproctitle.x86_64: I: checking python3-setproctitle.x86_64: W: spelling-error %description -l en_US ps -> PS, pa, pd The value of this tag appears to be misspelled. Please double-check. python3-setproctitle.x86_64: W: spelling-error %description -l en_US multi -> mulch, mufti The value of this tag appears to be misspelled. Please double-check. python3-setproctitle.x86_64: I: checking-url http://pypi.python.org/pypi/setproctitle (timeout 10 seconds) 1 packages and 0 specfiles checked; 0 errors, 2 warnings. notes: python3 variant is provided as it is supported upstream. Modules has been tested and working on both python 2.7/3.2 (fedora 16 & rawhide)
I will take the review. First thing : %install rm -rf %{buildroot} should be removed 2nd thing : the tests ( make check ) are not run, and that should be :)
all done, i mention that tests are broken with python3, for the moment they well be executed but won't fail the build. Spec URL: http://hguemar.fedorapeople.org/review/python-setproctitle.spec SRPM URL: http://hguemar.fedorapeople.org/review/python-setproctitle-1.1.3-2.fc16.src.rpm
Package Review ============== Key: - = N/A x = Pass ! = Fail ? = Not evaluated ==== C/C++ ==== [x]: MUST Header files in -devel subpackage, if present. [x]: MUST Package does not contain any libtool archives (.la) [x]: MUST Package does not contain kernel modules. [x]: MUST Package contains no static executables. [x]: MUST Rpath absent or only used for internal libs. [x]: MUST Package is not relocatable. [!]: MUST Development .so files in -devel subpackage, if present. Note: python-setproctitle-1.1.3-2.fc18.i686.rpm : /usr/lib/python2.7 /site-packages/setproctitle.so python3-setproctitle-1.1.3-2.fc18.i686.rpm : /usr/lib/python3.2/site-packages/setproctitle.cpython-32mu.so ==== Generic ==== [x]: MUST Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: MUST Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: MUST All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: MUST Buildroot is not present Note: Unless packager wants to package for EPEL5 this is fine [x]: MUST Package contains no bundled libraries. [x]: MUST Changelog in prescribed format. [x]: MUST Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: Clean would be needed if support for EPEL is required [x]: MUST Sources contain only permissible code or content. [x]: MUST Each %files section contains %defattr if rpm < 4.4 Note: Note: defattr macros not found. They would be needed for EPEL5 [x]: MUST Macros in Summary, %description expandable at SRPM build time. [x]: MUST Package requires other packages for directories it uses. [x]: MUST Package uses nothing in %doc for runtime. [x]: MUST Package is not known to require ExcludeArch. [x]: MUST Permissions on files are set properly. [x]: MUST Package does not contain duplicates in %files. [x]: MUST Spec file lacks Packager, Vendor, PreReq tags. [x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf would be needed if support for EPEL5 is required [x]: MUST If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: MUST License field in the package spec file matches the actual license. [x]: MUST License file installed when any subpackage combination is installed. [x]: MUST Package consistently uses macros (instead of hard-coded directory names). [x]: MUST Package meets the Packaging Guidelines. [x]: MUST Package is named according to the Package Naming Guidelines. [x]: MUST Package does not generates any conflict. [x]: MUST Package obeys FHS, except libexecdir and /usr/target. [x]: MUST Package must own all directories that it creates. [x]: MUST Package does not own files or directories owned by other packages. [x]: MUST Package installs properly. [x]: MUST Requires correct, justified where necessary. [!]: MUST Rpmlint output is silent. rpmlint python3-setproctitle-1.1.3-2.fc18.i686.rpm python3-setproctitle.i686: W: spelling-error %description -l en_US ps -> PS, pa, pd python3-setproctitle.i686: W: spelling-error %description -l en_US multi -> mulch, mufti 1 packages and 0 specfiles checked; 0 errors, 2 warnings. rpmlint python-setproctitle-1.1.3-2.fc18.src.rpm python-setproctitle.src: W: spelling-error %description -l en_US ps -> PS, pa, pd python-setproctitle.src: W: spelling-error %description -l en_US multiprocess -> multiprocessor, multiprocessing 1 packages and 0 specfiles checked; 0 errors, 2 warnings. rpmlint python-setproctitle-debuginfo-1.1.3-2.fc18.i686.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. rpmlint python-setproctitle-1.1.3-2.fc18.i686.rpm python-setproctitle.i686: W: spelling-error %description -l en_US ps -> PS, pa, pd python-setproctitle.i686: W: spelling-error %description -l en_US multiprocess -> multiprocessor, multiprocessing 1 packages and 0 specfiles checked; 0 errors, 2 warnings. [x]: MUST Sources used to build the package match the upstream source, as provided in the spec URL. /home/misc/review/785592/setproctitle-1.1.3.tar.gz : MD5SUM this package : 64028521850dc68c5b90d45377de3f5c MD5SUM upstream package : 64028521850dc68c5b90d45377de3f5c [x]: MUST Spec file is legible and written in American English. [x]: MUST Spec file name must match the spec package %{name}, in the format %{name}.spec. [-]: MUST Package contains a SysV-style init script if in need of one. [x]: MUST File names are valid UTF-8. [x]: SHOULD Reviewer should test that the package builds in mock. [x]: SHOULD If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: SHOULD Dist tag is present. [x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q --requires). [x]: SHOULD Package functions as described. [x]: SHOULD Package does not include license text files separate from upstream. [x]: SHOULD SourceX is a working URL. [x]: SHOULD Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: SHOULD Package should compile and build into binary rpms on all supported architectures. [x]: SHOULD %check is present and all tests pass. [x]: SHOULD Packages should try to preserve timestamps of original installed files. [x]: SHOULD Spec use %global instead of %define. Issues: [!]: MUST Development .so files in -devel subpackage, if present. Note: python-setproctitle-1.1.3-2.fc18.i686.rpm : /usr/lib/python2.7 /site-packages/setproctitle.so python3-setproctitle-1.1.3-2.fc18.i686.rpm : /usr/lib/python3.2/site-packages/setproctitle.cpython-32mu.so [!]: MUST Rpmlint output is silent. rpmlint python3-setproctitle-1.1.3-2.fc18.i686.rpm python3-setproctitle.i686: W: spelling-error %description -l en_US ps -> PS, pa, pd python3-setproctitle.i686: W: spelling-error %description -l en_US multi -> mulch, mufti 1 packages and 0 specfiles checked; 0 errors, 2 warnings. rpmlint python-setproctitle-1.1.3-2.fc18.src.rpm python-setproctitle.src: W: spelling-error %description -l en_US ps -> PS, pa, pd python-setproctitle.src: W: spelling-error %description -l en_US multiprocess -> multiprocessor, multiprocessing 1 packages and 0 specfiles checked; 0 errors, 2 warnings. rpmlint python-setproctitle-debuginfo-1.1.3-2.fc18.i686.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. rpmlint python-setproctitle-1.1.3-2.fc18.i686.rpm python-setproctitle.i686: W: spelling-error %description -l en_US ps -> PS, pa, pd python-setproctitle.i686: W: spelling-error %description -l en_US multiprocess -> multiprocessor, multiprocessing 1 packages and 0 specfiles checked; 0 errors, 2 warnings. Generated by fedora-review 0.1.2 External plugins: So the spelling-error are false positive, the package work fine on fedora 16. So I think the package is good to go.
New Package SCM Request ======================= Package Name: python-setproctitle Short Description: Python module to customize a process title Owners: hguemar Branches: f15 f16 f17 InitialCC:
Git done (by process-git-requests).
python-setproctitle-1.1.3-2.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/python-setproctitle-1.1.3-2.fc17
python-setproctitle-1.1.3-2.fc17 has been pushed to the Fedora 17 testing repository.
python-setproctitle-1.1.3-2.fc17 has been pushed to the Fedora 17 stable repository.
Package Change Request ====================== Package Name: python-setproctitle New Branches: el6 Owners: stevetraylen See bug#1001562 where fedora packager is happy for me to proceed.