Bug 785722 - Review all possible logging levels setting
Summary: Review all possible logging levels setting
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat Satellite
Classification: Red Hat
Component: katello-agent
Version: 6.0.1
Hardware: Unspecified
OS: Unspecified
unspecified
low vote
Target Milestone: Unspecified
Assignee: Bryan Kearney
QA Contact: Katello QA List
URL:
Whiteboard:
Depends On: 804127
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-01-30 13:04 UTC by Lukas Zapletal
Modified: 2019-09-26 13:29 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-08-22 18:23:25 UTC
Target Upstream Version:

Attachments (Terms of Use)
Add an attachment (proposed patch, testcase, etc.)

Description Lukas Zapletal 2012-01-30 13:04:24 UTC 
When KATELLO_LOGGING is set to warn this code is wrong:

https://github.com/ohadlevy/katello/blob/master/src/app/models/glue/pulp/user.rb#L39

If this method (or any orchestration action) returns false (or nil), our
orchestration is stopped with an error.

Unfortunately (or thankfully) after Bryan's patch (setting logging level to
info) the Rails.logger.info statement started to return nil which 
effectively stopped our orchestration.

We should review all possible logging levels and run some tests. The best would be to run katello system tests.
Comment 1 Lukas Zapletal 2012-02-07 12:16:46 UTC 
No regressions there.
Comment 2 Garik Khachikyan 2012-03-26 09:19:20 UTC 
Better to do now with: https://bugzilla.redhat.com/show_bug.cgi?id=804127
Comment 3 Jeff Weiss 2012-04-27 13:35:40 UTC 
This bug is just to make sure there were no nasty regressions like the orchestration errors mentioned earlier.  We haven't seen any, Verified.

CloudForms System Engine Version: 0.1.309-1.el6
Comment 5 Mike McCune 2013-08-16 18:23:53 UTC 
getting rid of 6.0.0 version since that doesn't exist
Note You need to log in before you can comment on or make changes to this bug.