Spec URL: http://fedorapeople.org/~dcallagh/gunicorn/gunicorn.spec
SRPM URL: http://fedorapeople.org/~dcallagh/gunicorn/gunicorn-0.13.4-1.fc16.src.rpm
Gunicorn ("Green Unicorn") is a Python WSGI HTTP server for UNIX. It uses the
pre-fork worker model, ported from Ruby's Unicorn project. It supports WSGI,
Django, and Paster applications.
Updated to address an intermittent build problem caused by test failures. Reported upstream:
New spec and SRPM:
I'll take this for a review.
- The package should be named python-gunicorn.
- I think that Group: should be "System Environment/Daemons", as it is with other web servers like apache or httpd (not sure if this can actually run as a daemon, but I suppose it can).
- You should have BR: python2-devel according to .
- You should probably rather BR: python-setuptools than python-setuptools-devel: it seems to me, that the trend is to move to python-setuptools, as the package python-setuptools obsoletes python-setuptools-devel and only provides it for backward compatibility.
- Otherwise the package looks good and also works, so as soon as you correct these issues, it can be approved.
Thanks for taking this review Bohuslav!
(In reply to comment #3)
> - The package should be named python-gunicorn.
At first I picked gunicorn and not python-gunicorn, because the package is a binary and not a Python library. But now that I read the guidelines more closely I see that you're right -- gunicorn is really an "addon" package for Python because it's not useful without a Python WSGI application to run.
> - I think that Group: should be "System Environment/Daemons", as it is with
> other web servers like apache or httpd (not sure if this can actually run as a
> daemon, but I suppose it can).
That makes sense. It is possible (and intended) to run gunicorn as a daemon, although I personally am not using it that way. Actually it should be easy to write a systemd unit for it. I will do that and add it to this package.
> - You should have BR: python2-devel according to .
> - You should probably rather BR: python-setuptools than
> python-setuptools-devel: it seems to me, that the trend is to move to
> python-setuptools, as the package python-setuptools obsoletes
> python-setuptools-devel and only provides it for backward compatibility.
I have been living in RHEL5-land for too long :-) I will fix these up.
The issues mentioned in comment 3 are now fixed:
I haven't added a systemd unit because gunicorn will need to gain support for socket activation before it can be used with systemd. I started writing a patch, but it's not straightforward because Python does not seem to have a way to call getsockname() on an existing file descriptor. I will work on this some more in future.
The package is ok now => APPROVED.
New Package SCM Request
Package Name: python-gunicorn
Short Description: Python WSGI application server
Branches: f15 f16 el6
Git done (by process-git-requests).
python-gunicorn-0.13.4-3.fc16 has been submitted as an update for Fedora 16.
python-gunicorn-0.13.4-3.fc15 has been submitted as an update for Fedora 15.
python-gunicorn-0.13.4-3.el6 has been submitted as an update for Fedora EPEL 6.
python-gunicorn-0.13.4-3.fc16 has been pushed to the Fedora 16 testing repository.
python-gunicorn-0.13.4-3.fc16 has been pushed to the Fedora 16 stable repository.
python-gunicorn-0.13.4-3.fc15 has been pushed to the Fedora 15 stable repository.
python-gunicorn-0.13.4-3.el6 has been pushed to the Fedora EPEL 6 stable repository.