Description of problem:

tomcat as a service is not properly detected due to different command line detection needed


Version-Release number of selected component (if applicable):

2.4.1, 3.0.0

How reproducible:

always

Steps to Reproduce:
1. Install the exe version of Tomcat 6 on Windows, and have it installed as a service (the installer allows that, or do it manually).
2. Start the service.
3. install an agent on windows
4. discovery -f

Actual results:

Tomcat is not found

Expected results:

The opposite..... to find tomcat

Additional info:

when starting as a service, task manager in windows will show the process as:

Image name: tomcat6.exe
User: SYSTEM
Command line: "c:\path\Tomcat 6.0.33\bin\Tomcat6.exe" //RS/Tomcat6

(use menu: View/Select columns  to make the cmd line visible)

Looking at:

modules/plugins/tomcat/src/main/java/org/​boss/on/​plugins/tomcat/​ TomcatDiscoveryComponent.java

241 String catalinaHome = determineCatalinaHome(commandLine);
242 
243 if (catalinaHome == null && isWindows(context)) {
244    log.debug("catalina.home not found. ...
...
250     catalinaHome = determineCatalinaHomeOnWindows(processInfo);
251  }

determineCatalinaHome in line 241 returns null, looking at it:

321     private String determineCatalinaHome(String[] cmdLine) {
322         String result = null;
323 
324         for (int i = 0; i < cmdLine.length; ++i) {
325             String line = cmdLine[i];
326             if (line.startsWith(PROPERTY_CATALINA_HOME)) {
327                 result = line.substring(PROPERTY_CATALINA_HOME.length());
328                 break;
329             }
330         }

This test will always fail of course for a windows service - see command line format above.

So we fall throught to line 250 determineCatalinaHomeOnWindows
There the code relies on "apache-tomcat-" directory, so relying on it being a EWS tomcat only, hence fails again to discover out tomcat service.

When determineCatalinaHomeOnWindows() fails to find anything, an additional test should be done with a simple JMX connection that reads out the JVM arguments. The only caveat, is that a fixed/documented port number should be used which would limit detection to a single tomcat instance.

Cross referencing: https://bugzilla.redhat.com/show_bug.cgi?id=756456

as that BZ is also about Tomcat as a service.