Bug 786276 - twinkle crashes on incoming calls
Summary: twinkle crashes on incoming calls
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: twinkle
Version: 16
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: ---
Assignee: Kevin Fenzi
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-01-31 22:07 UTC by Michele Baldessari
Modified: 2012-02-10 21:53 UTC (History)
2 users (show)

Fixed In Version: twinkle-1.4.2-16.fc16
Clone Of:
Environment:
Last Closed: 2012-02-10 21:53:35 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
patch to fix assert (513 bytes, patch)
2012-01-31 22:07 UTC, Michele Baldessari
no flags Details | Diff

Description Michele Baldessari 2012-01-31 22:07:12 UTC
Description of problem:
Twinkle crashes on incoming calls

Version-Release number of selected component (if applicable):


How reproducible:
Once it starts crashing, it simply crashes at every incoming call

Steps to Reproduce:
1. Receive an incoming call
2.
3.
  
Actual results:
Segfault (assert exception)

Expected results:


Additional info:
In src/userintf.cpp +3247 the following event is created:

void t_userintf::cb_async_display_msg(const string &msg, t_msg_priority prio) { 
        t_event_ui *event = new t_event_ui(TYPE_UI_CB_DISPLAY_MSG);
        MEMMAN_NEW(event);
        
        event->set_display_msg(msg, prio);
        evq_ui_events.push(event);
}

Events are generally caught in src/event.cpp (oid t_event_ui::exec(t_userintf *user_intf). The problem is that this event is never caught as it is not present in the switch / case set:
void t_event_ui::exec(t_userintf *user_intf) {
        switch (type) {
        case TYPE_UI_CB_DTMF_DETECTED:
                ui->cb_dtmf_detected(line, dtmf_event);
                break;
        case TYPE_UI_CB_SEND_DTMF:
                ui->cb_send_dtmf(line, dtmf_event);
                break;
        case TYPE_UI_CB_RECV_CODEC_CHANGED:
                ui->cb_recv_codec_changed(line, codec);
                break;
        case TYPE_UI_CB_LINE_STATE_CHANGED:
                ui->cb_line_state_changed();
                break;
        case TYPE_UI_CB_LINE_ENCRYPTED:
                ui->cb_line_encrypted(line, encrypted, cipher_mode);
                break;
        case TYPE_UI_CB_SHOW_ZRTP_SAS:
                ui->cb_show_zrtp_sas(line, zrtp_sas);
                break;
        case TYPE_UI_CB_ZRTP_CONFIRM_GO_CLEAR:
                ui->cb_zrtp_confirm_go_clear(line);
                break;
        case TYPE_UI_CB_QUIT:
                ui->cmd_quit();
                break;
        default:
                assert(false);
        }
}

As TYPE_UI_CB_DISPLAY_MSG is missing there we will hit assert.

Patch attached.

RH colleague of mine (luvilla) also confirmed this fixes this for him

cheers,
Michele

Comment 1 Michele Baldessari 2012-01-31 22:07:53 UTC
Created attachment 558712 [details]
patch to fix assert

Comment 2 Fedora Update System 2012-02-01 22:03:54 UTC
twinkle-1.4.2-16.fc16 has been submitted as an update for Fedora 16.
https://admin.fedoraproject.org/updates/twinkle-1.4.2-16.fc16

Comment 3 Fedora Update System 2012-02-02 17:32:55 UTC
Package twinkle-1.4.2-16.fc16:
* should fix your issue,
* was pushed to the Fedora 16 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing twinkle-1.4.2-16.fc16'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2012-1217/twinkle-1.4.2-16.fc16
then log in and leave karma (feedback).

Comment 4 Fedora Update System 2012-02-10 21:53:35 UTC
twinkle-1.4.2-16.fc16 has been pushed to the Fedora 16 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.