Bug 786748 - systemd service script seems broken
Summary: systemd service script seems broken
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: cherokee
Version: 16
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Pavel Lisý
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-02-02 10:06 UTC by Matthias Runge
Modified: 2012-03-07 18:39 UTC (History)
3 users (show)

Fixed In Version: cherokee-1.2.101-3.el5
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-03-01 09:27:53 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Matthias Runge 2012-02-02 10:06:14 UTC
Description of problem:
systemctl start cherokee.service 
does not work

starting via 

/usr/sbin/cherokee -d -C /etc/cherokee/cherokee.conf

works well.

[root@mrungexp plugins]# systemctl start cherokee.service 

[takes some time, during this time, cherokee works]

Job failed. See system logs and 'systemctl status' for details.

After last output, cherokee gets killed.


Version-Release number of selected component (if applicable):
cherokee-1.2.101-1.fc16.x86_64

How reproducible:
every time

Steps to Reproduce:
1. don't start cherokee on boot
2. systemctl start cherokee.service
3. 
  
Actual results:

cherokee works, service script takes time to return, cherokee is killed


Expected results:
starting cherokee starts, script returns and cherokee is still working.


Additional info:
I'm using selinux, but can't find something cherokee-related in logs.

Comment 1 Matthias Runge 2012-02-02 10:10:39 UTC
Ah, syslogs contain


Feb  2 11:05:23 mrungexp systemd[1]: PID file /var/run/cherokee not readable (yet?) after start.
Feb  2 11:05:23 mrungexp cherokee[15749]: Cherokee Web Server 1.2.101 (Oct 19 2011): Listening on port ALL:80, TLS
Feb  2 11:05:23 mrungexp cherokee[15749]: disabled, IPv6 enabled, using epoll, 4096 fds system limit, max. 2041
Feb  2 11:05:23 mrungexp cherokee[15749]: connections, 20 threads, 102 connections per thread, standard scheduling policy
Feb  2 11:06:53 mrungexp systemd[1]: cherokee.service operation timed out. Terminating.
Feb  2 11:06:53 mrungexp cherokee[15749]: Server is exiting..
Feb  2 11:06:53 mrungexp systemd[1]: Unit cherokee.service entered failed state.

[root@mrungexp cherokee]# cat /etc/cherokee/cherokee.conf | grep \/var\/run
server!pid_file = /var/run/cherokee.pid

Comment 2 Matthias Runge 2012-02-02 10:22:30 UTC
Disabling pid-file doesn't change the situation,

solution: just drop from service file:
 
PIDFile=/var/run/cherokee

AFAIK, pid-file is not needed anymore. systemd creates a process group for every service. If no process is running in service group, service is dead.

Comment 3 Renich Bon Ciric 2012-02-08 20:20:02 UTC
I added a .pid to the PIDFile

PIDFile=/var/run/cherokee.pid

and this seems to be a workaround the problem. Can somebody confirm this?

Comment 4 Pavel Lisý 2012-02-21 10:57:08 UTC
It looks problem was in inconsistency between 
/etc/cherokee/cherokee.conf and /lib/systemd/system/cherokee.service

I'll make new rpm with 
PIDFile=/var/run/cherokee.pid
in /lib/systemd/system/cherokee.service.

Comment 5 Fedora Update System 2012-02-21 13:23:35 UTC
cherokee-1.2.101-3.fc16 has been submitted as an update for Fedora 16.
https://admin.fedoraproject.org/updates/cherokee-1.2.101-3.fc16

Comment 6 Fedora Update System 2012-02-21 13:24:03 UTC
cherokee-1.2.101-3.fc15 has been submitted as an update for Fedora 15.
https://admin.fedoraproject.org/updates/cherokee-1.2.101-3.fc15

Comment 7 Fedora Update System 2012-02-21 13:24:45 UTC
cherokee-1.2.101-3.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/cherokee-1.2.101-3.el6

Comment 8 Fedora Update System 2012-02-21 13:25:11 UTC
cherokee-1.2.101-3.el5 has been submitted as an update for Fedora EPEL 5.
https://admin.fedoraproject.org/updates/cherokee-1.2.101-3.el5

Comment 9 Fedora Update System 2012-02-21 13:25:36 UTC
cherokee-1.2.101-3.el4 has been submitted as an update for Fedora EPEL 4.
https://admin.fedoraproject.org/updates/cherokee-1.2.101-3.el4

Comment 10 Fedora Update System 2012-02-21 16:52:26 UTC
Package cherokee-1.2.101-3.el4:
* should fix your issue,
* was pushed to the Fedora EPEL 4 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=epel-testing cherokee-1.2.101-3.el4'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-EPEL-2012-0550/cherokee-1.2.101-3.el4
then log in and leave karma (feedback).

Comment 11 Fedora Update System 2012-03-01 09:27:53 UTC
cherokee-1.2.101-3.fc16 has been pushed to the Fedora 16 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 12 Fedora Update System 2012-03-01 09:35:52 UTC
cherokee-1.2.101-3.fc15 has been pushed to the Fedora 15 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 13 Fedora Update System 2012-03-07 18:39:11 UTC
cherokee-1.2.101-3.el6 has been pushed to the Fedora EPEL 6 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 14 Fedora Update System 2012-03-07 18:39:47 UTC
cherokee-1.2.101-3.el5 has been pushed to the Fedora EPEL 5 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.