Bug 787083 - Login template should indicate when local auth is not enabled
Summary: Login template should indicate when local auth is not enabled
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: PulpDist
Classification: Community
Component: Web App
Version: unspecified
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: 0.1.0
Assignee: Nick Coghlan
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-02-03 05:38 UTC by Nick Coghlan
Modified: 2012-02-06 04:34 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-02-06 04:34:20 UTC


Attachments (Terms of Use)

Description Nick Coghlan 2012-02-03 05:38:55 UTC
If a login attempt fails, the failure message is not displayed.

This is almost certainly a problem with the custom login template.

Comment 1 Nick Coghlan 2012-02-06 00:33:51 UTC
Turns out I completely misdiagnosed this misbehaviour.

When deployed in a production configuration, PulpDist expects the *web server* to deal with user authentication and pass that information along.

If the login template gets displayed, it's an indication that the web server has allowed an unauthenticated user to access a page that requires authentication (or there's a bug in the interaction between the web server and PulpDist).

Either way, the login template should be clearly indicating this rather than offering a login page that isn't actually going to do anything.

Comment 2 Nick Coghlan 2012-02-06 03:35:43 UTC
In the next release, the login page replaces the form with a notice if local auth is not supported.

Comment 3 Nick Coghlan 2012-02-06 03:37:05 UTC
Reopening - Django admin section appears to be using the wrong login template

Comment 4 Nick Coghlan 2012-02-06 04:34:20 UTC
Changed the login template to accept the additional info it needs as attributes on the login form instead of as context variables. This allows that info to be passed to both the normal and admin login view as class attributes on an AuthenticationForm subclass.


Note You need to log in before you can comment on or make changes to this bug.