Red Hat Satellite engineering is moving the tracking of its product development work on Satellite to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "Satellite project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs will be migrated starting at the end of May. If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "Satellite project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/SAT-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 787226 - Environment renaming should be disabled
Summary: Environment renaming should be disabled
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat Satellite
Classification: Red Hat
Component: API
Version: 6.0.0
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: Unspecified
Assignee: Tom McKay
QA Contact: Garik Khachikyan
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-02-03 15:55 UTC by Justin Sherrill
Modified: 2019-09-25 21:08 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-08-22 18:24:45 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Description Justin Sherrill 2012-02-03 15:55:28 UTC
Since we base the repoid in pulp off of the environment name, we really shouldn't be able to rename it, as it could cause problems. 

One such scenario that could cause issues:


1. create environment Dev
2. promote repo X to dev
3. rename environment Dev to Foo
4. Create a new environment called Dev after Foo
5. promote repo X to Dev


Since the repo was already created in an environment called Dev, the repo promotion would fail.  


Ideally we wouldn't be basing repo_id off of environment name.  There was some discussion on having an immutable label field, which should allow us to have a name that is changeable, but this is probably post V1.


We need to block this in the UI and the api.

Comment 1 Ivan Necas 2012-02-21 10:21:16 UTC
Update on model level and removed from CLI in commit fad3a89dd63471a3b233097079a2e709c208d9a2

Comment 3 Ivan Necas 2012-02-21 10:24:50 UTC
Since the preventing of name update is achieved by validation, and so this change also affected UI (user gets descriptive error message after trying to update the environment name), the possibility to update it in UI should be fully removed from the UI.

@justin could you take care of it?, thx

Comment 4 Tom McKay 2012-02-21 19:38:30 UTC
Disabling edit from UI.

Comment 5 Tom McKay 2012-02-21 20:04:54 UTC
commit 94e403f15a3dcbf99ebec6dae5e7a3466d66eb09
Author: Tom McKay <thomasmckay>
Date:   Tue Feb 21 15:04:30 2012 -0500

    787226 - removed 'editable' form env name form field

Comment 7 Garik Khachikyan 2012-02-22 15:10:51 UTC
# VERIFIED

both API and CLI have disabled with environment name rename option.

checked:
---
katello-0.1.243-1.git.0.a066880.el6.noarch
katello-cli-0.1.57-1.git.0.4e2dd9a.el6.noarch
pulp-0.0.266-1.el6.noarch
candlepin-0.5.20-1.el6.noarch
---


Note You need to log in before you can comment on or make changes to this bug.