Bug 788448 - No explanation of "Force console keyboard shortcuts"
Summary: No explanation of "Force console keyboard shortcuts"
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: virt-manager
Version: 16
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Cole Robinson
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-02-08 08:48 UTC by Kamil Páral
Modified: 2012-02-23 02:27 UTC (History)
7 users (show)

Fixed In Version: virt-manager-0.9.1-2.fc15
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-02-17 23:53:53 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Kamil Páral 2012-02-08 08:48:14 UTC
Description of problem:
In virt-manager preferences there is a checkbox:

"Force console keyboard shortcuts"

I have no idea what that means. There is no tooltip available. There is no help available.

Please add documentation to explain what this option means. Preferably a descriptive tooltip.

Version-Release number of selected component (if applicable):
virt-manager-0.9.1-1.fc16.noarch

Comment 1 Cole Robinson 2012-02-08 17:37:47 UTC
There is a descriptive tooltip, so not sure why that isn't popping up for you. It states:

Force console menu accelerators while the console is active. Enabling this may overwrite keyboard interaction with the guest.

So closing this as NOTABUG. Please reopen if you can't get the tooltip to work or if you think that description can be improved.

Comment 2 Cole Robinson 2012-02-08 17:40:41 UTC
And actually I've changed the desc upstream to say override instead of overwrite (which sounds destructive).

Comment 3 Kamil Páral 2012-02-09 12:46:24 UTC
OK, now I know why I didn't see the tooltip. I was hovering over the checkbox, but the tooltip displays only when hovering over the label. Please make the checkbox also display the same tooltip.

As for tooltip description, I have to admit I still have no idea what is means. What are "console menu accelerators"? Is that Ctrl+Alt+F1 and similar shortcuts? Or something else? Maybe an example would clear that up.

(Ticking that checkbox and hitting Ctrl+Alt+F2 still switches consoles on the host and not on the guest, so I guess it does something completely different than I expected.)

Comment 4 Cole Robinson 2012-02-13 21:15:24 UTC
Things like ctrl+alt+f2 are caught by X on the host and we have no way to override those.

Accelerators are things like Alt+F opening the File menu. Normally when the guest graphical console has keyboard/mouse grab, we disable those accelerators in the virt-manager window, so that Alt+F is sent to the guest and doesn't invoke File virt-manager window.

I've changed the tooltip text to the following:

When the guest graphical console has keyboard focus, do not disable shortcuts for console window menus (Alt+F -> File, etc.) Normally these are disabled to ensure that typing in the guest does not accidentally perform an operation in virt-manager's console window.

I've added that text to the checkbox as well, and renamed the option to 'Don't disable console shortcuts:'

http://git.fedorahosted.org/git?p=virt-manager.git;a=commit;h=fbef52dbfe662843ff471b6f4dd44354aa820cba

Tho honestly now that i've thought about it some, I'll probably just remove this option in the next release, since it's a mouthful to explain and I don't really understand the purpose for it. Sure some people that are just using VTs in the guest might not need to send alt+f to the guest for anything and would want to control virt-manager window operations, but that use case is so limited it's not worth supporting with a preferences option.

Comment 5 Fedora Update System 2012-02-14 00:32:19 UTC
virt-manager-0.9.1-2.fc16 has been submitted as an update for Fedora 16.
https://admin.fedoraproject.org/updates/virt-manager-0.9.1-2.fc16

Comment 6 Fedora Update System 2012-02-14 00:43:05 UTC
virt-manager-0.9.1-2.fc15 has been submitted as an update for Fedora 15.
https://admin.fedoraproject.org/updates/virt-manager-0.9.1-2.fc15

Comment 7 Kamil Páral 2012-02-14 09:20:56 UTC
(In reply to comment #4)
> Accelerators are things like Alt+F opening the File menu. Normally when the
> guest graphical console has keyboard/mouse grab, we disable those accelerators
> in the virt-manager window, so that Alt+F is sent to the guest and doesn't
> invoke File virt-manager window.
> 
> I've changed the tooltip text to the following:
> 
> When the guest graphical console has keyboard focus, do not disable shortcuts
> for console window menus (Alt+F -> File, etc.) Normally these are disabled to
> ensure that typing in the guest does not accidentally perform an operation in
> virt-manager's console window.

I finally understand that! :-)

I know what 'menu accelerators' (slightly better term is probably 'accelerator keys') are. But I was confused with the 'console' prefix, which means simply the VM window, but I was thinking about switching VT-x all the time.

> Tho honestly now that i've thought about it some, I'll probably just remove
> this option in the next release, since it's a mouthful to explain and I don't
> really understand the purpose for it. Sure some people that are just using VTs
> in the guest might not need to send alt+f to the guest for anything and would
> want to control virt-manager window operations, but that use case is so limited
> it's not worth supporting with a preferences option.

Agreed, I find that option quite confusing. When the VM has the focus, I expect all keyboard shortcuts to be forwarded.

Comment 8 Fedora Update System 2012-02-15 11:29:28 UTC
Package virt-manager-0.9.1-2.fc16:
* should fix your issue,
* was pushed to the Fedora 16 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing virt-manager-0.9.1-2.fc16'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2012-1671/virt-manager-0.9.1-2.fc16
then log in and leave karma (feedback).

Comment 9 Fedora Update System 2012-02-17 23:53:53 UTC
virt-manager-0.9.1-2.fc16 has been pushed to the Fedora 16 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 10 Fedora Update System 2012-02-23 02:27:05 UTC
virt-manager-0.9.1-2.fc15 has been pushed to the Fedora 15 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.