RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 789220 - memory leak on client programming failure path
Summary: memory leak on client programming failure path
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 6
Classification: Red Hat
Component: libvirt
Version: 6.3
Hardware: x86_64
OS: Linux
high
high
Target Milestone: rc
: ---
Assignee: Alex Jia
QA Contact: Virtualization Bugs
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-02-10 05:54 UTC by Alex Jia
Modified: 2012-06-20 06:48 UTC (History)
6 users (show)

Fixed In Version: libvirt-0.9.10-1.el6
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-06-20 06:48:10 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2012:0748 0 normal SHIPPED_LIVE Low: libvirt security, bug fix, and enhancement update 2012-06-19 19:31:38 UTC

Description Alex Jia 2012-02-10 05:54:40 UTC 
Description of problem:
Memory leak on client programming failure path.

Version-Release number of selected component (if applicable):
# rpm -q libvirt
libvirt-0.9.10-0rc2.el6.x86_64

How reproducible:
always

Steps to Reproduce:
# valgrind -v --leak-check=full virsh -c qemu:

Note, give a incomplete qemu/xen URI etc.
  
Actual results:

==7373== 40 bytes in 1 blocks are definitely lost in loss record 7 of 26
==7373==    at 0x4A04A28: calloc (vg_replace_malloc.c:467)
==7373==    by 0x4C72C9D: virAlloc (memory.c:101)
==7373==    by 0x4D2FAE8: virNetClientProgramNew (virnetclientprogram.c:60)
==7373==    by 0x4D1F034: doRemoteOpen (remote_driver.c:658)
==7373==    by 0x4D213EF: remoteOpen (remote_driver.c:871)
==7373==    by 0x4CEDCA0: do_open (libvirt.c:1196)
==7373==    by 0x4CEEDC5: virConnectOpenAuth (libvirt.c:1422)
==7373==    by 0x423447: main (virsh.c:18526)
==7373== 
==7373== 40 bytes in 1 blocks are definitely lost in loss record 8 of 26
==7373==    at 0x4A04A28: calloc (vg_replace_malloc.c:467)
==7373==    by 0x4C72C9D: virAlloc (memory.c:101)
==7373==    by 0x4D2FAE8: virNetClientProgramNew (virnetclientprogram.c:60)
==7373==    by 0x4D1F057: doRemoteOpen (remote_driver.c:664)
==7373==    by 0x4D213EF: remoteOpen (remote_driver.c:871)
==7373==    by 0x4CEDCA0: do_open (libvirt.c:1196)
==7373==    by 0x4CEEDC5: virConnectOpenAuth (libvirt.c:1422)
==7373==    by 0x423447: main (virsh.c:18526)
==7373== 
==7373== LEAK SUMMARY:
==7373==    definitely lost: 80 bytes in 2 blocks

Expected results:
fix client memory leaks on failure path.

Additional info:
Comment 1 Alex Jia 2012-02-10 05:55:43 UTC 
The patch has been sent to upstream and wait for review:
https://www.redhat.com/archives/libvir-list/2012-February/msg00519.html
Comment 2 Alex Jia 2012-02-10 07:24:04 UTC 
The path has been ACKed and pushed:

commit 6d514728cc88a0df4c2d334c771fdd9122f46b15
Author: Alex Jia <ajia>
Date:   Fri Feb 10 13:26:29 2012 +0800

    rpc: Plug memory leaks on doRemoteOpen() failure path
    
    Detected by valgrind. Leaks are introduced in commit c1b2264.
    
    * src/remote/remote_driver.c (doRemoteOpen): free client program memory in failure path.
    
    * How to reproduce?
    % valgrind -v --leak-check=full virsh -c qemu:
Comment 4 xhu 2012-02-15 06:38:05 UTC 
Reproduce it with libvirt-0.9.10-0rc2.el6.x86_64.
Verify it with libvirt-0.9.10-1.el6 and it passed.
Comment 6 errata-xmlrpc 2012-06-20 06:48:10 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHSA-2012-0748.html
Note You need to log in before you can comment on or make changes to this bug.