790402 – sosreport should blank root password in anaconda plugin

RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.

Bug 790402 - sosreport should blank root password in anaconda plugin

Summary: sosreport should blank root password in anaconda plugin

Keywords:
Status:	CLOSED ERRATA
Alias:	None
Product:	Red Hat Enterprise Linux 6
Classification:	Red Hat
Component:	sos
Sub Component:
Version:	6.2
Hardware:	Unspecified
OS:	Unspecified
Priority:	unspecified
Severity:	unspecified
Target Milestone:	rc
Target Release:	---
Assignee:	Bryn M. Reeves
QA Contact:	David Kutálek
Docs Contact:
URL:
Whiteboard:
Depends On:
Blocks:	CVE-2012-2664
TreeView+	depends on / blocked

Reported:	2012-02-14 12:46 UTC by Philip Rowlands
Modified:	2012-06-20 07:25 UTC (History)
CC List:	5 users (show)
Fixed In Version:	sos-2.2-18.el6
Doc Type:	Bug Fix
Doc Text:	* Previous versions of the sos anaconda module would not elide password configuration from collected kickstart configuration files * This may lead to unintended disclosure of these password settings * The sosreport command now applies a string substitution when collection these files to ensure passwords are obscured * Generated reports no longer include this possibly sensitive information while still retaining important diagnostic data from the module
Clone Of:
Environment:
Last Closed:	2012-06-20 07:25:42 UTC
Target Upstream Version:
Embargoed:

Attachments	(Terms of Use)

Links
System	ID	Private	Priority	Status	Summary	Last Updated
Red Hat Product Errata	RHSA-2012:0958	0	normal	SHIPPED_LIVE	Low: sos security, bug fix, and enhancement update	2012-06-19 19:28:28 UTC

Description Philip Rowlands 2012-02-14 12:46:37 UTC

sosreport's "anaconda" plugin collects /root/anaconda-ks.cfg, which contains the root password for the system, possibly crypt'd, possibly plain.

sosreport should blank this password in a similar way to the ldap plugin's treatment of bindpw in /etc/ldap.conf

Suggested patch for plugins/anaconda.py:

def postproc(self):
    self.doRegexSub("/root/anaconda-ks.cfg", r"(\s*rootpw\s*)\S+", r"\1***")
    return

Comment 2 Philip Rowlands 2012-02-14 13:08:33 UTC

Correction: this should be fixed in both the anaconda and general plugins, which both collect /root/anaconda-ks.cfg. Alternatively take it out of general, as the anaconda plugin is enabled by default.

Comment 3 Bryn M. Reeves 2012-02-14 13:15:19 UTC

Thanks for the suggested patch.

Agreed, I don't think there's any need to collect this in the general module (generally we're trying to reduce the number of duplicated path copy specs as they potentially mask bugs).

The proposed regex substitution seems fine. I'll get this posted upstream and queued for an update.

Comment 6 Bryn M. Reeves 2012-05-01 13:34:36 UTC

    Technical note added. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    New Contents:
* Previous versions of the sos anaconda module would not elide password configuration from collected kickstart configuration files
* This may lead to unintended disclosure of these password settings
* The sosreport command now applies a string substitution when collection these files to ensure passwords are obscured
* Generated reports no longer include this possibly sensitive information while still retaining important diagnostic data from the module

Comment 9 errata-xmlrpc 2012-06-20 07:25:42 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHSA-2012-0958.html

Note You need to log in before you can comment on or make changes to this bug.