Bugzilla will be upgraded to version 5.0. The upgrade date is tentatively scheduled for 2 December 2018, pending final testing and feedback.
Bug 790402 - sosreport should blank root password in anaconda plugin
sosreport should blank root password in anaconda plugin
Status: CLOSED ERRATA
Product: Red Hat Enterprise Linux 6
Classification: Red Hat
Component: sos (Show other bugs)
6.2
Unspecified Unspecified
unspecified Severity unspecified
: rc
: ---
Assigned To: Bryn M. Reeves
David Kutálek
:
Depends On:
Blocks: CVE-2012-2664
  Show dependency treegraph
 
Reported: 2012-02-14 07:46 EST by Philip Rowlands
Modified: 2012-06-20 03:25 EDT (History)
5 users (show)

See Also:
Fixed In Version: sos-2.2-18.el6
Doc Type: Bug Fix
Doc Text:
* Previous versions of the sos anaconda module would not elide password configuration from collected kickstart configuration files * This may lead to unintended disclosure of these password settings * The sosreport command now applies a string substitution when collection these files to ensure passwords are obscured * Generated reports no longer include this possibly sensitive information while still retaining important diagnostic data from the module
Story Points: ---
Clone Of:
Environment:
Last Closed: 2012-06-20 03:25:42 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)


External Trackers
Tracker ID Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2012:0958 normal SHIPPED_LIVE Low: sos security, bug fix, and enhancement update 2012-06-19 15:28:28 EDT

  None (edit)
Description Philip Rowlands 2012-02-14 07:46:37 EST
sosreport's "anaconda" plugin collects /root/anaconda-ks.cfg, which contains the root password for the system, possibly crypt'd, possibly plain.

sosreport should blank this password in a similar way to the ldap plugin's treatment of bindpw in /etc/ldap.conf

Suggested patch for plugins/anaconda.py:

def postproc(self):
    self.doRegexSub("/root/anaconda-ks.cfg", r"(\s*rootpw\s*)\S+", r"\1***")
    return
Comment 2 Philip Rowlands 2012-02-14 08:08:33 EST
Correction: this should be fixed in both the anaconda and general plugins, which both collect /root/anaconda-ks.cfg. Alternatively take it out of general, as the anaconda plugin is enabled by default.
Comment 3 Bryn M. Reeves 2012-02-14 08:15:19 EST
Thanks for the suggested patch.

Agreed, I don't think there's any need to collect this in the general module (generally we're trying to reduce the number of duplicated path copy specs as they potentially mask bugs).

The proposed regex substitution seems fine. I'll get this posted upstream and queued for an update.
Comment 6 Bryn M. Reeves 2012-05-01 09:34:36 EDT
    Technical note added. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    New Contents:
* Previous versions of the sos anaconda module would not elide password configuration from collected kickstart configuration files
* This may lead to unintended disclosure of these password settings
* The sosreport command now applies a string substitution when collection these files to ensure passwords are obscured
* Generated reports no longer include this possibly sensitive information while still retaining important diagnostic data from the module
Comment 9 errata-xmlrpc 2012-06-20 03:25:42 EDT
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHSA-2012-0958.html

Note You need to log in before you can comment on or make changes to this bug.