Bug 790531 - Review Request: PyQt4-webkit - Python bindings for Qt4 Webkit package epel 6
Summary: Review Request: PyQt4-webkit - Python bindings for Qt4 Webkit package epel 6
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora EPEL
Classification: Fedora
Component: Package Review
Version: el6
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Jaroslav Reznik
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 767762 (view as bug list)
Depends On:
Blocks: 767714
TreeView+ depends on / blocked
 
Reported: 2012-02-14 19:08 UTC by Than Ngo
Modified: 2012-02-28 14:51 UTC (History)
3 users (show)

Fixed In Version: PyQt4-webkit-4.6.2-8.el6
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-02-22 18:02:21 UTC
Type: ---
jreznik: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Than Ngo 2012-02-14 19:08:23 UTC
Spec URL: http://than.fedorapeople.org/PyQt4-webkit.spec
SRPM URL:
http://than.fedorapeople.org/PyQt4-webkit-4.6.2-8.el6.src.rpm

This is a PyQt4 webkit package that can be installed in parallel with the RHEL
PyQt4 package. It provides webkit support and will only be requested for the el6 branch.

Comment 1 Jaroslav Reznik 2012-02-21 11:15:52 UTC
Summary: ok
Name: ok
License: ok
Group: ok
Url: ok
Sources: see rpmlint output, ok
BuildRoot: ok, but nod needed for el6
BRs: ok
Reqs: ok
Description: ok
Macros used consistently: ok
Files: %docs ok

Defining Python macros is not needed anymore, applies for <=5.
Package does not conflicts with el6 PyQt4 as webkit submodule is disabled there.

rpmlint PyQt4-webkit-4.6.2-8.el6.src.rpm 
PyQt4-webkit.src:29: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 29)

Np for review, just fix it before import.

PyQt4-webkit.src: W: invalid-url Source0: http://www.riverbankcomputing.com/static/Downloads/PyQt4/PyQt-x11-gpl-4.6.2.tar.gz HTTP Error 404: Not Found
1 packages and 0 specfiles checked; 0 errors, 2 warnings.

Old 4.6.2 sources are not available anymore upstream, we need it for EL6. But the sources are already in EL6.

Comment 2 Jaroslav Reznik 2012-02-21 11:46:53 UTC
One issue - please require PyQt4 package.

Comment 3 Jaroslav Reznik 2012-02-21 11:51:28 UTC
Scratchbuild: ok, http://koji.fedoraproject.org/koji/taskinfo?taskID=3807019

Comment 4 Than Ngo 2012-02-21 12:30:50 UTC
> 
> rpmlint PyQt4-webkit-4.6.2-8.el6.src.rpm 
> PyQt4-webkit.src:29: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line
> 29)

fixed

> 
> Np for review, just fix it before import.
> 
> PyQt4-webkit.src: W: invalid-url Source0:
> http://www.riverbankcomputing.com/static/Downloads/PyQt4/PyQt-x11-gpl-4.6.2.tar.gz
> HTTP Error 404: Not Found
> 1 packages and 0 specfiles checked; 0 errors, 2 warnings.
> 
> Old 4.6.2 sources are not available anymore upstream, we need it for EL6. But
> the sources are already in EL6.

fixed


new spec file and srpm is uploaded on same place

Comment 5 Jaroslav Reznik 2012-02-21 12:53:53 UTC
Thanks Than,
APPROVED

Comment 6 Than Ngo 2012-02-21 13:03:44 UTC
New Package SCM Request
=======================
Package Name: PyQt4-webkit
Short Description: Python bindings for Qt4 Webkit
Owners: than
Branches: el6

Comment 7 Gwyn Ciesla 2012-02-21 13:41:22 UTC
Git done (by process-git-requests).

Comment 8 Fedora Update System 2012-02-21 16:41:42 UTC
PyQt4-webkit-4.6.2-8.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/PyQt4-webkit-4.6.2-8.el6

Comment 9 Fedora Update System 2012-02-22 18:02:21 UTC
PyQt4-webkit-4.6.2-8.el6 has been pushed to the Fedora EPEL 6 stable repository.

Comment 10 Rex Dieter 2012-02-28 14:50:32 UTC
*** Bug 767762 has been marked as a duplicate of this bug. ***


Note You need to log in before you can comment on or make changes to this bug.