Bug 790533 - katello shell offers 'product promote' command ... should it?
Summary: katello shell offers 'product promote' command ... should it?
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat Satellite
Classification: Red Hat
Component: katello-agent
Version: 6.0.0
Hardware: Unspecified
OS: Unspecified
medium
low
Target Milestone: Unspecified
Assignee: Lukas Zapletal
QA Contact: Og Maciel
URL:
Whiteboard:
Depends On:
Blocks: katello-blockers
TreeView+ depends on / blocked
 
Reported: 2012-02-14 19:10 UTC by James Laska
Modified: 2019-09-26 15:55 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-08-22 18:27:12 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Description James Laska 2012-02-14 19:10:26 UTC
Description of problem:

The katello shell offers content promotion via creation, update and promotion of changesets.  There appears to be one other method for promoting content.  The 'product' command offers a 'product promote' sub-command.

Is this expected to work?  This doesn't trigger errors when used, but should katello offer two distinct methods for promoting content?

> katello> product -h
> Usage: katello <options> product <action> <options>
> Supported Actions:
> 	create         create new product to a custom provider
> 	update         update a product's attributes
> 	list           list known products
> 	delete         delete a product and its content
> 	synchronize    synchronize a product
> 	cancel_sync    cancel currently running synchronization
> 	status         status of product's synchronization
> 	promote        promote a product to an environment
> 	               (creates a temporary changeset with the product and promotes it)
> 	list_filters   list filters of a product
> 	add_filter     add a filter to a product
> 	remove_filter  remove a filter from a product
> 	set_plan       set a synchronization plan
> 	remove_plan    unset a synchronization plan
> 
> Options:
>   -h, --help  show this help message and exit

Version-Release number of selected component (if applicable):
 * katello-0.1.235-2.el6.noarch

Steps to Reproduce:
1. katello -u admin -p admin shell
2. product promote --name 'Red Hat Enterprise Linux Server' --org redhat --environment Stage

Actual results:

It didn't fail, which seems good on the surface

Expected results:

Why does the product command support promotion without a changeset?  No other content commands support promotion.

Additional info:

Comment 1 Mike McCune 2012-02-14 19:32:30 UTC
it actually does create a changeset.  If you look in the UI you get:


"'product_promotion_2012-02-15 03:30:10.556174"

but I don't see any entry in the changeset history which is bad.

So I'm going to leave this open because we must show the changeset in the history in the UI

Comment 2 Lukas Zapletal 2012-02-20 09:15:55 UTC
I assume this is still blocker. Taking.

Comment 3 Lukas Zapletal 2012-02-20 12:50:48 UTC
Ok so the CLI explicitely removes the changeset. Removing this behavior upstream:

7806152 790533 - 'product promote' no longer delete changeset

Comment 4 James Laska 2012-02-20 13:00:52 UTC
Thanks Lukáš, moving to MODIFIED as a fix is in upstream comment per comment#3

Comment 6 Og Maciel 2012-03-01 16:50:20 UTC
Validated:
* candlepin-0.5.23-1.el6.noarch
* candlepin-tomcat6-0.5.23-1.el6.noarch
* katello-0.1.300-1.el6.noarch
* katello-all-0.1.300-1.el6.noarch
* katello-certs-tools-1.0.2-2.el6.noarch
* katello-cli-0.1.100-2.el6.noarch
* katello-cli-common-0.1.100-2.el6.noarch
* katello-common-0.1.300-1.el6.noarch
* katello-configure-0.1.100-7.el6.noarch
* katello-glue-candlepin-0.1.300-1.el6.noarch
* katello-glue-foreman-0.1.300-1.el6.noarch
* katello-glue-pulp-0.1.300-1.el6.noarch
* katello-httpd-ssl-key-pair-1.0-1.noarch
* katello-qpid-broker-key-pair-1.0-1.noarch
* katello-repos-0.1.5-1.el6.noarch
* katello-selinux-0.1.7-1.el6.noarch
* katello-trusted-ssl-cert-1.0-1.noarch
* pulp-1.0.0-4.el6.noarch
* pulp-common-1.0.0-4.el6.noarch
* pulp-selinux-server-1.0.0-4.el6.noarch


Note You need to log in before you can comment on or make changes to this bug.