Bug 790549 - Review Request: relaxngcc - RELAX NG Compiler Compiler
Summary: Review Request: relaxngcc - RELAX NG Compiler Compiler
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: ---
Assignee: Andy Grimm
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 790553 796201
TreeView+ depends on / blocked
 
Reported: 2012-02-14 20:03 UTC by Juan Hernández
Modified: 2016-11-08 03:46 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-02-15 18:04:56 UTC
Type: ---
Embargoed:
agrimm: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Juan Hernández 2012-02-14 20:03:10 UTC
Spec URL:

http://jhernand.fedorapeople.org/rpms/relaxngcc/3/relaxngcc.spec

SRPM URL:

http://jhernand.fedorapeople.org/rpms/relaxngcc/3/relaxngcc-1.12-3.fc17.src.rpm

Description:

RelaxNGCC is a tool for generating Java source code from a given RELAX NG
grammar. By embedding code fragments in the grammar like yacc or JavaCC, you can
take appropriate actions while parsing valid XML documents against the grammar.

Comment 1 Andy Grimm 2012-02-15 15:52:09 UTC
=== REQUIRED ITEMS ===
[!]  Rpmlint output:
relaxngcc.src: W: spelling-error %description -l en_US yacc -> yak, Yacc, ya cc
relaxngcc.noarch: E: explicit-lib-dependency msv-xsdlib
relaxngcc.noarch: W: spelling-error %description -l en_US yacc -> yak, Yacc, ya cc
3 packages and 0 specfiles checked; 1 errors, 2 warnings.

The error here is due to a legitimate java requirement which happens to have a package name with "lib" in it.  I have file BZ 790869 for this.

[x]  Package is named according to the Package Naming Guidelines[1].
[x]  Spec file name must match the base package name, in the format %{name}.spec.
[x]  Package meets the Packaging Guidelines[2].
[x]  Package successfully compiles and builds into binary rpms.
[x]  Buildroot definition is not present
[x]  Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines[3,4].
[x]  License field in the package spec file matches the actual license.
License type: ASL 1.1
[x]  If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc.
[x]  All independent sub-packages have license of their own
[x]  Spec file is legible and written in American English.
[x]  Sources used to build the package matches the upstream source, as provided in the spec URL.
MD5SUM this package    : e79a12522d22cdda704376daf3c2e8b2
MD5SUM upstream package: e79a12522d22cdda704376daf3c2e8b2
[x]  All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines[5].
[x]  Package must own all directories that it creates or must require other packages for directories it uses.
[x]  Package does not contain duplicates in %files.
[x]  File sections do not contain %defattr(-,root,root,-) unless changed with good reason
[x]  Permissions on files are set properly.
[x]  Package does NOT have a %clean section which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT). (not needed anymore)
[x]  Package consistently uses macros (no %{buildroot} and $RPM_BUILD_ROOT mixing)
[x]  Package contains code, or permissable content.
[-]  Fully versioned dependency in subpackages, if present.
[-]  Package contains a properly installed %{name}.desktop file if it is a GUI application.
[x]  Package does not own files or directories owned by other packages.
[x]  Javadoc documentation files are generated and included in -javadoc subpackage
[x]  Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlinks)
[x]  Packages have proper BuildRequires/Requires on jpackage-utils
[x]  Javadoc subpackages have Require: jpackage-utils
[x]  Package uses %global not %define
[-]  If package uses tarball from VCS include comment how to re-create that tarball (svn export URL, git clone URL, ...)
[x]  If source tarball includes bundled jar/class files these need to be removed prior to building
[x]  All filenames in rpm packages must be valid UTF-8.
[x]  Jar files are installed to %{_javadir}/%{name}.jar (see [6] for details)
[-]  If package contains pom.xml files install it (including depmaps) even when building with ant
[-]  pom files has correct add_maven_depmap

=== Maven ===
Not applicable

=== Other suggestions ===
[x]  If possible use upstream build method (maven/ant/javac)
[x]  Avoid having BuildRequires on exact NVR unless necessary
[x]  Package has BuildArch: noarch (if possible)
[x]  Latest version is packaged.
[x]  Reviewer should test that the package builds in mock.
Tested on: F17


=== ISSUES ===
None noted.

APPROVED.

Comment 2 Juan Hernández 2012-02-15 17:23:10 UTC
New Package SCM Request
=======================
Package Name: relaxngcc
Short Description: RELAX NG Compiler Compiler 
Owners: jhernand
Branches: f17
InitialCC: goldmann

Comment 3 Gwyn Ciesla 2012-02-15 17:35:56 UTC
Git done (by process-git-requests).


Note You need to log in before you can comment on or make changes to this bug.