Bug 790743 - afr: Internal locks need to [un]set lk_owners before and after [un]locking phases resp.
Summary: afr: Internal locks need to [un]set lk_owners before and after [un]locking ph...
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: GlusterFS
Classification: Community
Component: replicate
Version: mainline
Hardware: All
OS: All
high
urgent
Target Milestone: ---
Assignee: krishnan parthasarathi
QA Contact:
URL:
Whiteboard:
: 790755 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-02-15 10:07 UTC by krishnan parthasarathi
Modified: 2015-12-01 16:45 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-03-13 17:49:29 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:


Attachments (Terms of Use)
Test app as mentioned in "steps to reproduce". (342 bytes, text/x-python)
2012-02-15 10:07 UTC, krishnan parthasarathi
no flags Details

Description krishnan parthasarathi 2012-02-15 10:07:18 UTC
Created attachment 562178 [details]
Test app as mentioned in "steps to reproduce".

Description of problem:
inodelk, entrylk need to set lk_owner 'differently' to ensure two inode modify operations have different lk_owners. The issue is that they dont unset it after the internal locking phase is over, leaving posix lock fops have different owners despite coming from the same application. This can leave stale posix locks at the server(s).

Version-Release number of selected component (if applicable):
mainline

How reproducible:
Consistently

Steps to Reproduce:
1. Hold a fcnlt F_WRLOCK on a section of a file via SETLK_W.
2. Kill the application holding the lock.
3. Run the app (See attachement for eg app) in Step 1 again and you will see a blocked posix lock.
  
Actual results:
Application in Step3 will see a blocked posix lock.

Expected results:
The application should not see a blocked lock.


Additional info:
Usage of attached app:
- python <attached-app> <path of file to lock>

Comment 1 krishnan parthasarathi 2012-02-15 17:00:32 UTC
*** Bug 790755 has been marked as a duplicate of this bug. ***

Comment 2 Anand Avati 2012-03-01 16:23:55 UTC
CHANGE: http://review.gluster.com/2752 (afr: [Un]Set the 'right' lkowner for [f]{inode|entry}_lk and the 'enclosed' fop.) merged in master by Vijay Bellur (vijay)

Comment 3 Amar Tumballi 2012-03-12 09:46:46 UTC
please update these bugs w.r.to 3.3.0qa27, need to work on it as per target milestone set.

Comment 4 krishnan parthasarathi 2012-03-13 17:49:29 UTC
The above patch has been reverted. This bug will not be fixed, since a patch (under development) would make flush fops non-transaction in afr. Marking this as wont fix.


Note You need to log in before you can comment on or make changes to this bug.