RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 790744 - Delete snapshot parent will crash libvirtd
Summary: Delete snapshot parent will crash libvirtd
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 6
Classification: Red Hat
Component: libvirt
Version: 6.3
Hardware: x86_64
OS: Linux
high
high
Target Milestone: rc
: ---
Assignee: Eric Blake
QA Contact: Virtualization Bugs
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-02-15 10:09 UTC by Alex Jia
Modified: 2012-06-20 06:48 UTC (History)
7 users (show)

Fixed In Version: libvirt-0.9.10-2.el6
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-06-20 06:48:22 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2012:0748 0 normal SHIPPED_LIVE Low: libvirt security, bug fix, and enhancement update 2012-06-19 19:31:38 UTC

Description Alex Jia 2012-02-15 10:09:11 UTC 
Description of problem:
Delete snapshot parent with many children will crash libvirtd.

Version-Release number of selected component (if applicable):
libvirt-0.9.10-1.el6.x86_64

How reproducible:
always

Steps to Reproduce:
1. qemu-img create -f qcow2 /var/lib/libvirt/images/foo.qcow2 10M
2. virsh edit guest configuration and let guest disk source point to the image file
3. # virsh snapshot-create-as foo snap
Domain snapshot snap created

# virsh snapshot-list foo
 Name                 Creation Time             State
------------------------------------------------------------
 snap                 2012-02-15 17:51:18 +0800 running

# virsh snapshot-create foo
Domain snapshot 1329299507 created

# virsh snapshot-create foo
Domain snapshot 1329299512 created

# virsh snapshot-list foo --parent
 Name                 Creation Time             State           Parent
------------------------------------------------------------
 1329299507           2012-02-15 17:51:47 +0800 running         snap
 1329299512           2012-02-15 17:51:52 +0800 running         1329299507
 snap                 2012-02-15 17:51:18 +0800 running

4. # virsh snapshot-delete --children foo snap
error: Failed to delete snapshot snap
error: End of file while reading data: Input/output error

Actual results:
libvirtd crash

Expected results:
fix it.

Additional info:
Comment 1 Alex Jia 2012-02-15 10:16:42 UTC 
Eric has committed a patch for the issues:
https://www.redhat.com/archives/libvir-list/2012-February/msg00662.html
Comment 2 Eric Blake 2012-02-16 00:39:17 UTC 
In POST:
http://post-office.corp.redhat.com/archives/rhvirt-patches/2012-February/msg00778.html
Comment 5 zhpeng 2012-02-22 07:22:21 UTC 
Test with libvirt-0.9.10-2.el6.x86_64

virsh # list 
 Id Name                 State
----------------------------------
  1 kvm1                 running
# virsh dumpxml kvm1
..
    <disk type='file' device='disk'>
      <driver name='qemu' type='qcow2' cache='none'/>
      <source file='/var/lib/libvirt/images/foo.img.qcow2'/>
      <target dev='vda' bus='virtio'/>
      <alias name='virtio-disk0'/>
      <address type='pci' domain='0x0000' bus='0x00' slot='0x05' function='0x0'/>
    </disk>
..

virsh # snapshot-create-as kvm1 snap
Domain snapshot snap created
virsh # snapshot-create kvm1 
Domain snapshot 1329895045 created
virsh # snapshot-create kvm1 
Domain snapshot 1329895048 created
virsh # snapshot-create kvm1 
Domain snapshot 1329895053 created
virsh # snapshot-create kvm1 
Domain snapshot 1329895056 created
virsh # snapshot-create kvm1 
Domain snapshot 1329895061 created
virsh # snapshot-list kvm1 --parent
 Name                 Creation Time             State           Parent
------------------------------------------------------------
 1329895045           2012-02-22 15:17:25 +0800 running         snap
 1329895048           2012-02-22 15:17:28 +0800 running         1329895045
 1329895053           2012-02-22 15:17:33 +0800 running         1329895048
 1329895056           2012-02-22 15:17:36 +0800 running         1329895053
 1329895061           2012-02-22 15:17:41 +0800 running         1329895056
 snap                 2012-02-22 15:17:09 +0800 running

virsh # snapshot-delete --children kvm1 snap
Domain snapshot snap deleted

virsh # snapshot-list kvm1 --parent
 Name                 Creation Time             State           Parent
------------------------------------------------------------

[root@zhpeng ~]# service libvirtd status
libvirtd (pid  5271) is running...


So, it passed.
Comment 7 errata-xmlrpc 2012-06-20 06:48:22 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHSA-2012-0748.html
Note You need to log in before you can comment on or make changes to this bug.