Red Hat Bugzilla – Bug 791280
Memory leaks and crasher in sphinx3_get_hypothesis found in cmusphinx3-0.8-10.fc17 using gcc-with-cpychecker static analyzer
Last modified: 2012-02-28 05:58:48 EST
Description of problem:
I've been writing an experimental static analysis tool to detect bugs commonly occurring within C Python extension modules:
I ran the latest version of the tool (in git master; post 0.9) on
cmusphinx3-0.8-10.fc17.src.rpm, and it reports various errors.
You can see a list of errors here, triaged into categories (from most significant to least significant):
The two reported reference leaks appear to be genuine bugs: in this code:
231 return Py_BuildValue("(OO)", hypstr_obj, hypseg_obj);
both hypstr_obj and hypseg_obj are references owned by the function.
The "O" format codes to Py_BuildValue build the 2-tuple by adding additional references. It should instead use the "N" format code to transfer ownership of the owned references to the new tuple. See:
The reported "Segfaults within error-handling paths" appears to also be a genuine bug: there isn't any checking for the possibility that this call:
206 hypseg_obj = PyTuple_New(nhyps);
fails (e.g. under low-memory conditions), returning NULL, and this pointer is then written through at:
228 PyTuple_SET_ITEM(hypseg_obj, i, seg_obj);
There may of course be other bugs in my checker tool.
Hope this is helpful; let me know if you need help reading the logs that the tool generates - I know that it could use some improvement.
Version-Release number of selected component (if applicable):
gcc-python-plugin post-0.9 git 073d390de53ef52136bd90e5ac06f1ef833d047d running the checker in an *f16* chroot
Ah, very cool. I'm a big fan of static analysis tools myself. I'll forward your report upstream and work with them to fix these bugs. Thanks!
A patch to fix both issues was accepted upstream. I'll apply the patch and rebuild. Thanks again.
cmusphinx3-0.8-11.fc17 has been submitted as an update for Fedora 17.
* should fix your issue,
* was pushed to the Fedora 17 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing cmusphinx3-0.8-11.fc17'
as soon as you are able to.
Please go to the following url:
then log in and leave karma (feedback).
cmusphinx3-0.8-11.fc17 has been pushed to the Fedora 17 stable repository. If problems still persist, please make note of it in this bug report.