Bug 794320 (JBEPP-1369) - Enable customization of LocalConfig service by extending existing implementations
Summary: Enable customization of LocalConfig service by extending existing implementat...
Keywords:
Status: CLOSED NEXTRELEASE
Alias: JBEPP-1369
Product: JBoss Enterprise Portal Platform 5
Classification: JBoss
Component: Portal
Version: 5.1.1.GA,5.2.0.ER06
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: ---
: 5.2.1.GA
Assignee: Marko Strukelj
QA Contact:
URL: http://jira.jboss.org/jira/browse/JBE...
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-11-17 12:07 UTC by Martin Weiler
Modified: 2018-11-26 18:20 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2012-02-16 09:42:44 UTC
Type: Enhancement
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Issue Tracker JBEPP-1369 0 None Closed Enable customization of LocalConfig service by extending existing implementations 2012-03-28 00:32:23 UTC

Description Martin Weiler 2011-11-17 12:07:27 UTC
Help Desk Ticket Reference: https://na7.salesforce.com/500A0000008UBgS
project_key: JBEPP

Creating custom implementations of the LocaleConfig and LocaleConfigService interfaces is not possible by extending the existing implementations. Most methods are declared final or private.

The current implementations should be changed so that they can be easily extended. Otherwise unnecessary code duplication has to be done.

Comment 1 Martin Weiler 2011-11-17 12:07:27 UTC
Link: Added: This issue Cloned from GTNPORTAL-2278


Comment 2 Martin Weiler 2011-11-17 12:08:17 UTC
NEEDINFO: Added: Nobody


Comment 3 Martin Weiler 2011-11-17 12:08:31 UTC
Link: Removed: This issue Cloned from GTNPORTAL-2278 


Comment 4 Martin Weiler 2011-11-17 12:08:51 UTC
Link: Added: This issue depends GTNPORTAL-2278


Comment 5 Martin Weiler 2011-11-17 12:09:23 UTC
Help Desk Ticket Reference: Added: https://na7.salesforce.com/500A0000008UBgS


Comment 8 Jared MORGAN 2011-11-18 02:42:57 UTC
Release Notes Docs Status: Added: Not Yet Documented
Release Notes Text: Added: CAUSE:

CONSEQUENCE:

FIX:

RESULT:


Comment 9 hfnukal@redhat.com 2012-01-13 11:25:07 UTC
Labels: Added: EPP_5_2_1_Candidate


Comment 11 Thomas Heute 2012-02-16 09:41:34 UTC
Labels: Removed: EPP_5_2_1_Candidate 


Comment 14 Marko Strukelj 2012-02-16 13:52:17 UTC
Release Notes Text: Removed: CAUSE:

CONSEQUENCE:

FIX:

RESULT: Added: CAUSE: Many methods in LocaleConfigImpl, and LocaleConfigServiceImpl were final or private.

CONSEQUENCE: Users were unable to reuse existing implementation by extending and overriding - they were forced to copy-paste in order to implement alternative behaviour.

FIX: Remove final from methods, make private method protected.

RESULT: Users should now be able to extend, and override the default LocaleConfig implementation.


Comment 15 Marko Strukelj 2012-03-23 13:21:12 UTC
    Technical note added. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    New Contents:
CAUSE: Many methods in LocaleConfigImpl, and
LocaleConfigServiceImpl were final or private.

CONSEQUENCE: Users were unable to reuse existing implementation by extending
and overriding - they were forced to copy-paste in order to implement
alternative behaviour.

FIX: Remove final from methods, make private method protected.

RESULT: Users should now be able to extend, and override the default
LocaleConfig implementation.

Comment 16 Jared MORGAN 2012-03-28 00:32:16 UTC
    Technical note updated. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    Diffed Contents:
@@ -1,11 +1,2 @@
-CAUSE: Many methods in LocaleConfigImpl, and
+It was discovered that many methods in LocaleConfigImpl, and
-LocaleConfigServiceImpl were final or private.
+LocaleConfigServiceImpl were declared final or private. Users were unable to reuse an existing implementation by extending and overriding the methods, and were forced to make a copy of the method to implement customized behavior. The fix removes the final declaration from these methods, and declares private methods as protected. This allows users to extend and override the default LocaleConfig implementation.-
-CONSEQUENCE: Users were unable to reuse existing implementation by extending
-and overriding - they were forced to copy-paste in order to implement
-alternative behaviour.
-
-FIX: Remove final from methods, make private method protected.
-
-RESULT: Users should now be able to extend, and override the default
-LocaleConfig implementation.


Note You need to log in before you can comment on or make changes to this bug.