Bug 794394 (JBEPP-1438) - Invalid page title of page causes unability to edit node
Summary: Invalid page title of page causes unability to edit node
Keywords:
Status: VERIFIED
Alias: JBEPP-1438
Product: JBoss Enterprise Portal Platform 5
Classification: JBoss
Component: Portal
Version: 5.2.0.GA
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: ---
: 5.2.1.ER02
Assignee: Nobody
QA Contact:
URL: http://jira.jboss.org/jira/browse/JBE...
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-12-06 16:13 UTC by Viliam Rockai
Modified: 2020-04-27 01:31 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
An issue with field value validation in page title fields caused angle brackets to be added verbatim to the page title. These verbatim characters resulted in portal page errors because the angle brackets were not substituted with HTML character references when the form was saved. The fix introduces NoHTMLTagValidator logic in page title fields, which prevents verbatim angle brackets from being entered into the field. Angle brackets can be included in titles, providing the correct HTML character references are declared: < and >
Clone Of:
Environment:
Last Closed:
Type: Bug
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Issue Tracker JBEPP-1438 0 Major Closed Invalid page title of page causes unability to edit node 2013-07-18 19:27:36 UTC

Description Viliam Rockai 2011-12-06 16:13:40 UTC
project_key: JBEPP

go to site menu
click on edit navigation for classic portal
click on edit node page for "sitemap" node
click on view page properties
put "Site Map<script>alert('a');</script>" into the page title
save

if you try now to edit node "sitemap" nothing will happen

Comment 1 Thomas Heute 2012-01-13 15:04:39 UTC
I can't reproduce on EPP 5.2 ? Viliam, any better description on how to reproduce ?

Comment 2 Viliam Rockai 2012-01-13 16:09:32 UTC
i was just able to reproduce again. let me rewrite the steps more detailed:

- login as root
- go to the "Site" menu
- click on "Edit Navigation" for "classic" portal
- on the "SiteMap" node right click and select "Edit Node's Page" from the menu
- in the "Page Editor" window on the right, click on "View page properties"
- put "Site Map<script>alert('a');</script>" into the "Page title" input
- save

if you try now to edit node "SiteMap" in "Edit Navigation" mode in "Site" asministrator page, nothing will happen. This issue causes even more troubles, like error with clicking on "View page properties" for other node pages.

Comment 5 Marko Strukelj 2012-03-06 10:52:21 UTC
    Technical note added. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    New Contents:
CAUSE: Entered text becomes part of portal page HTML as-is, including special characters like angle brackets
CONSEQUENCE: Entered text can break a portal page
FIX: Prevent entry of angle brackets using NoHTMLTagValidator
RESULT: Text that could break a portal page can't be entered any more. If angle brackets are desired in the output, character references can be used - &lt; and &gt;

Comment 6 Jared MORGAN 2012-03-27 23:20:12 UTC
    Technical note updated. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    Diffed Contents:
@@ -1,4 +1 @@
-CAUSE: Entered text becomes part of portal page HTML as-is, including special characters like angle brackets
+An issue with field value validation in page title fields caused angle brackets to be added verbatim to the page title. These verbatim characters resulted in portal page errors because the angle brackets were not substituted with HTML character references when the form was saved. The fix introduces NoHTMLTagValidator logic in page title fields, which prevents verbatim angle brackets from being entered into the field. Angle brackets can be included in titles, providing the correct HTML character references are declared: &amp;lt; and &amp;gt;-CONSEQUENCE: Entered text can break a portal page
-FIX: Prevent entry of angle brackets using NoHTMLTagValidator
-RESULT: Text that could break a portal page can't be entered any more. If angle brackets are desired in the output, character references can be used - &lt; and &gt;


Note You need to log in before you can comment on or make changes to this bug.