Bug 795099 (share-like-connect) - Review Request: share-like-connect - Share, like and connect concept for Plasma Active
Summary: Review Request: share-like-connect - Share, like and connect concept for Plas...
Keywords:
Status: CLOSED RAWHIDE
Alias: share-like-connect
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jaroslav Reznik
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: kde-reviews
TreeView+ depends on / blocked
 
Reported: 2012-02-19 11:06 UTC by Radek Novacek
Modified: 2016-12-01 00:30 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-02-22 11:01:59 UTC
Type: ---
Embargoed:
jreznik: fedora-review+


Attachments (Terms of Use)

Description Radek Novacek 2012-02-19 11:06:06 UTC
Spec URL: http://rnovacek.fedorapeople.org/share-like-connect.spec
SRPM URL: http://rnovacek.fedorapeople.org/share-like-connect-0.2-1.fc16.src.rpm
Description: Share, like and connect concept for Plasma Active.

Share-like-connect is part of Plasma Active project.

Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3802642

RPMLint result:
share-like-connect.x86_64: E: invalid-soname /usr/lib64/libactivecontentservice.so libactivecontentservice.so
share-like-connect.x86_64: E: invalid-soname /usr/lib64/libsharelikeconnect.so libsharelikeconnect.so
share-like-connect-devel.x86_64: W: no-documentation
4 packages and 1 specfiles checked; 2 errors, 1 warnings.

Comment 1 Jaroslav Reznik 2012-02-21 15:44:49 UTC
Name: ok
Summary: ok
License: ok, LGPLv2+
URL: ok
Sources: ok (md5sum 432df8b41c6bcf807f3db66c7b676139)
BRs: ok
Description: ok
Macros used consistently: ok
Ldconfig: ok
Docs: ok
File section: ok

Invalid soname: not ok, pls, check it.

Otherwise really simple package.

Comment 2 Jaroslav Reznik 2012-02-21 15:53:06 UTC
From KDE SIG meeting: "Unversioned shlibs are not a review blocker."

APPROVED

Comment 3 Radek Novacek 2012-02-21 16:14:39 UTC
New Package SCM Request
=======================
Package Name: share-like-connect
Short Description: Share, like and connect concept for Plasma Active
Owners: than rdieter jreznik ltinkl rnovacek kkofler
Branches: f17

Comment 4 Gwyn Ciesla 2012-02-21 16:21:35 UTC
Git done (by process-git-requests).

Comment 5 Fedora Update System 2012-02-22 10:59:57 UTC
share-like-connect-0.2-1.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/share-like-connect-0.2-1.fc17

Comment 6 Gwyn Ciesla 2012-02-22 13:31:49 UTC
This was already done, why set the cvs flag again?

Comment 7 Radek Novacek 2012-02-22 13:40:59 UTC
Sorry I had to set it by accident.

Comment 8 Fedora Update System 2012-02-28 10:42:00 UTC
share-like-connect-0.2-1.fc17 has been pushed to the Fedora 17 stable repository.


Note You need to log in before you can comment on or make changes to this bug.