Bug 795479 - Review Request: jboss-negotiation - JBoss Negotiation
Summary: Review Request: jboss-negotiation - JBoss Negotiation
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Juan Hernández
QA Contact: Fedora Extras Quality Assurance
Depends On:
TreeView+ depends on / blocked
Reported: 2012-02-20 16:38 UTC by Marek Goldmann
Modified: 2012-04-12 01:58 UTC (History)
4 users (show)

Fixed In Version: jboss-negotiation-2.2.0-3.SP1.fc17
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2012-04-12 01:58:46 UTC
Type: ---
juan.hernandez: fedora-review+
gwync: fedora-cvs+

Attachments (Terms of Use)

Comment 1 Juan Hernández 2012-03-23 09:19:04 UTC
I take this for review.

Comment 2 Juan Hernández 2012-03-28 10:18:25 UTC
Marek, can you please add the following to the spec?

BuildRequires: maven-surefire-provider-junit4

Comment 4 Juan Hernández 2012-03-29 16:28:00 UTC
Package Review

- = N/A
x = Check
! = Problem
? = Not evaluated

[x]  Rpmlint output:

Output of rpmlint of the source package:

$ rpmlint jboss-negotiation-2.2.0-2.SP1.fc17.src.rpm
jboss-negotiation.src: W: invalid-url URL: http://www.jboss.org/picketlink/Negotiation HTTP Error 403: Forbidden
jboss-negotiation.src:52: W: macro-in-comment %patch0
jboss-negotiation.src: W: invalid-url Source0: jboss-negotiation-2.2.0.SP1.tar.xz
1 packages and 0 specfiles checked; 0 errors, 3 warnings.

These warnings are acceptable.

Output of rpmlint of the binary packages:

$ rpmlint jboss-negotiation-2.2.0-2.SP1.fc18.noarch.rpm jboss-negotiation-javadoc-2.2.0-2.SP1.fc18.noarch.rpm
jboss-negotiation.noarch: W: invalid-url URL: http://www.jboss.org/picketlink/Negotiation HTTP Error 403: Forbidden
jboss-negotiation.noarch: W: no-documentation
jboss-negotiation-javadoc.noarch: W: spelling-error Summary(en_US) Javadocs -> Java docs, Java-docs, Avocados
jboss-negotiation-javadoc.noarch: W: invalid-url URL: http://www.jboss.org/picketlink/Negotiation HTTP Error 403: Forbidden
2 packages and 0 specfiles checked; 0 errors, 4 warnings.

These warnings are acceptable.

[x]  Package is named according to the Package Naming Guidelines[1].
[x]  Spec file name must match the base package name, in the format %{name}.spec.
[x]  Package meets the Packaging Guidelines[2].
[x]  Package successfully compiles and builds into binary rpms.

Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3943799

[x]  Buildroot definition is not present
[x]  Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines[3,4].
[x]  License field in the package spec file matches the actual license.

License type: LGPLv2+

[-]  If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc.
[-]  All independent sub-packages have license of their own
[x]  Spec file is legible and written in American English.
[x]  Sources used to build the package matches the upstream source, as provided in the spec URL.

Checked with a recursive diff ot the sources.

[x]  All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines[5].
[x]  Package must own all directories that it creates or must require other packages for directories it uses.
[x]  Package does not contain duplicates in %files.
[x]  File sections do not contain %defattr(-,root,root,-) unless changed with good reason
[x]  Permissions on files are set properly.
[x]  Package does NOT have a %clean section which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT). (not needed anymore)
[x]  Package consistently uses macros (no %{buildroot} and $RPM_BUILD_ROOT mixing)
[x]  Package contains code, or permissable content.
[-]  Fully versioned dependency in subpackages, if present.
[-]  Package contains a properly installed %{name}.desktop file if it is a GUI application.
[x]  Package does not own files or directories owned by other packages.
[x]  Javadoc documentation files are generated and included in -javadoc subpackage
[x]  Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlinks)
[x]  Packages have proper BuildRequires/Requires on jpackage-utils
[x]  Javadoc subpackages have Require: jpackage-utils
[x]  Package uses %global not %define
[x]  If package uses tarball from VCS include comment how to re-create that tarball (svn export URL, git clone URL, ...)
[-]  If source tarball includes bundled jar/class files these need to be removed prior to building
[x]  All filenames in rpm packages must be valid UTF-8.
[!]  Jar files are installed to %{_javadir}/%{name}.jar (see [6] for details)

The jar files in the package have the following names:


But according to the packaging guidelines they should use the names assigned by the build:


[x]  If package contains pom.xml files install it (including depmaps) even when building with ant
[x]  pom files has correct add_maven_depmap

=== Maven ===
[x]  Use %{_mavenpomdir} macro for placing pom files instead of %{_datadir}/maven2/poms
[-]  If package uses "-Dmaven.test.skip=true" explain why it was needed in a comment
[-]  If package uses custom depmap "-Dmaven.local.depmap.file=*" explain why it's needed in a comment
[x]  Package DOES NOT use %update_maven_depmap in %post/%postun
[x]  Packages DOES NOT have Requires(post) and Requires(postun) on jpackage-utils for %update_maven_depmap macro

=== Other suggestions ===
[x]  If possible use upstream build method (maven/ant/javac)
[x]  Avoid having BuildRequires on exact NVR unless necessary
[x]  Package has BuildArch: noarch (if possible)
[x]  Latest version is packaged.
[x]  Reviewer should test that the package builds in mock.

Tested on: http://koji.fedoraproject.org/koji/taskinfo?taskID=3943799

=== Issues ===
1. Names of the jar files don't follow the guidelines.

=== Final Notes ===
1. Fix issue #1 and I will approve.
2. Remove the commented out #%patch0 in line 52 (there is no corresponding Patch0).

Comment 6 Juan Hernández 2012-04-02 07:35:08 UTC
Looks good now. Thanks Marek.

*** APPROVED ***

Comment 7 Marek Goldmann 2012-04-02 07:47:04 UTC
Thanks for review!

New Package SCM Request
Package Name:      jboss-negotiation
Short Description: JBoss Negotiation
Owners:            goldmann
Branches:          f17

Comment 8 Gwyn Ciesla 2012-04-02 10:02:10 UTC
Git done (by process-git-requests).

Comment 9 Fedora Update System 2012-04-02 13:03:53 UTC
jboss-negotiation-2.2.0-3.SP1.fc17 has been submitted as an update for Fedora 17.

Comment 10 Fedora Update System 2012-04-02 17:45:42 UTC
jboss-negotiation-2.2.0-3.SP1.fc17 has been pushed to the Fedora 17 testing repository.

Comment 11 Fedora Update System 2012-04-12 01:58:46 UTC
jboss-negotiation-2.2.0-3.SP1.fc17 has been pushed to the Fedora 17 stable repository.

Note You need to log in before you can comment on or make changes to this bug.