Description of problem: When using --push-trans option, the python client submits extracted comments (#.) as though they are translator comments (# ). Translator comments appear to be ignored entirely. Version-Release number of selected component (if applicable): How reproducible: Always Steps to Reproduce: 1.Add comment lines above a message string in a .po file: # this is a translator comment #. this is an extracted comment 2.Add or change the translation for the message string 3.Run zanata push --push-trans 4.Download the .po file from the file download page Actual results: The following line is above the message string: # this is an extracted comment Expected results: The following line is above the message string: # this is a translator comment Additional info: Extracted comments from .pot files appear to be displayed properly. This is likely caused by re-use of the .pot comment parsing code for .po comment parsing.
Python client also appears not to write translator comments when pulling translations, only writes extracted comments.
This doesn't seem to happen with the maven client or file download.
Hi I have commit a change to git-hub to fix this issue, please check https://github.com/zanata/zanata-python-client/commit/5d500c75b1a6a8b2e9ca783d89cc262a9a0d1c0a to verify this issue.
Verified for commit 5d500c75b1a6a8b2e9ca783d89cc262a9a0d1c0a
Python client 1.3.4 still not outputting translator comments.
Hi Ding I think python client 1.3.4 doesn't include this change, you need to verify it with latest code. I am sorry about that, i will try to release a new version to include this modification soon.
hi James, I have tested it with python client version: 1.3.5-6-ga461. It can now generate translator comment when downloading .po via web UI. But it still doesn't output translator comment when pulling translation.
hi Joyce, Thanks a lot, i have test again, it is true that python client doesn't output translator comment when pulling translation. I made a fix and commit to git-hub, please check out source code on https://github.com/zanata/zanata-python-client/commit/118e4062d15b98fe1bf4e1fd27dcc623fbbd7f40 Thanks
thanks james, all good now! verified with zanata python client version: 1.3.5-8-g118e
zanata-python-client-1.3.7-1.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/zanata-python-client-1.3.7-1.fc16
zanata-python-client-1.3.7-1.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/zanata-python-client-1.3.7-1.el5
zanata-python-client-1.3.7-1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/zanata-python-client-1.3.7-1.fc17
zanata-python-client-1.3.7-1.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/zanata-python-client-1.3.7-1.fc15
zanata-python-client-1.3.7-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/zanata-python-client-1.3.7-1.el6
Package zanata-python-client-1.3.7-1.fc16: * should fix your issue, * was pushed to the Fedora 16 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing zanata-python-client-1.3.7-1.fc16' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2012-9357/zanata-python-client-1.3.7-1.fc16 then log in and leave karma (feedback).
Package zanata-python-client-1.3.7-1.el6: * should fix your issue, * was pushed to the Fedora EPEL 6 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=epel-testing zanata-python-client-1.3.7-1.el6' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-EPEL-2012-6156/zanata-python-client-1.3.7-1.el6 then log in and leave karma (feedback).
zanata-python-client-1.3.7-1.fc17 has been pushed to the Fedora 17 stable repository. If problems still persist, please make note of it in this bug report.