Bug 795690
| Summary: | RHEV-H 6.3: RHEV-H save invalid configuration | ||
|---|---|---|---|
| Product: | Red Hat Enterprise Linux 6 | Reporter: | cshao <cshao> |
| Component: | ovirt-node | Assignee: | Fabian Deutsch <fdeutsch> |
| Status: | CLOSED ERRATA | QA Contact: | Virtualization Bugs <virt-bugs> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | 6.3 | CC: | acathrow, bsarathy, fdeutsch, gouyang, jboggs, leiwang, mburns, ovirt-maint, sgordon, ycui |
| Target Milestone: | rc | ||
| Target Release: | 6.3 | ||
| Hardware: | x86_64 | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | ovirt-node-2.3.0-4.el6 | Doc Type: | Bug Fix |
| Doc Text: |
Previously, when configuring the Hypervisor, invalid input would be saved to disk and persisted, causing inconsistent or incorrect behavior. Now, when invalid input is detected, it is not persisted to the configuration files.
|
Story Points: | --- |
| Clone Of: | Environment: | ||
| Last Closed: | 2012-07-19 14:18:59 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
cshao
2012-02-21 10:04:52 UTC
My plan is to re-check the validity of all fields when the "Apply" button is pressed. If there are any fields with invalid values, a popup will appear naming the and request the user to fix them before the changes can be applied. Comments? sounds good, for the most part I believe the values if blank or incorrect will clear out, may want to check that first also make sure that navigating off the screen (up/down) doesn't cause an issue (it shouldn't, but doesn't hurt to double check) (In reply to comment #3) > sounds good, for the most part I believe the values if blank or incorrect will > clear out, may want to check that first That sounded like a good idea, the problem is that e.g. if someone enters a character as a port number, I can not just blank it, as this might be needed to write the configuration. Ok, I just saw (In reply to comment #5) > (In reply to comment #3) > > sounds good, for the most part I believe the values if blank or incorrect will > > clear out, may want to check that first Ok, I just saw how it's done on othe fields right now. This patch also does it this way: http://gerrit.ovirt.org/#change,3711 Tested as follows: - Installed node - Enter the TUI - Select the Logging page - Append an "a" to the max file size field - Leave the field using down-arrow or TAB - A dialog pops up, telling the field is containing an invalid value - Select "OK" = The field is reset to "1024" - Select the KDump page - Enable NFS - Change the NFS server field to "---" - Leave the field using down-arrow or TAB - A dialog pops up, telling the field is containing an invalid value - Select "OK" = The field is reset to "" - Press F2 to drop to shell - /etc/kdump.conf does not exist
Technical note added. If any revisions are required, please edit the "Technical Notes" field
accordingly. All revisions will be proofread by the Engineering Content Services team.
New Contents:
Previously, when configuring certain functionality, invalid input would be saved causing inconsistent or incorrect behavior. Now, when invalid input is detected, it will not be persisted to the configuration files.
Technical note updated. If any revisions are required, please edit the "Technical Notes" field
accordingly. All revisions will be proofread by the Engineering Content Services team.
Diffed Contents:
@@ -1 +1 @@
-Previously, when configuring certain functionality, invalid input would be saved causing inconsistent or incorrect behavior. Now, when invalid input is detected, it will not be persisted to the configuration files.+Previously, when configuring the Hypervisor, invalid input would be saved to disk and persisted, causing inconsistent or incorrect behavior. Now, when invalid input is detected, it is not persisted to the configuration files.
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. http://rhn.redhat.com/errata/RHBA-2012-0741.html |