Eclipse plugin uses deprecated hash symbol # for comments in newly created .drl files. Setting # to be deprecated might cause large refactoring work in existing .drl files, because Eclipse plugin used this type of comment as a default setting. Newly created .drl file in Eclipse looks like this: #created on: Feb 22, 2012 package com.sample #list any import classes here. #declare any global variables here rule "Your First Rule" when #conditions then #actions end Users should now use // for single comments and /* */ for block comments. But Eclipse plugin should not confuse them with #.
Max Rydahl Andersen <max.andersen> made a comment on jira JBIDE-11033 doesn't this depend on the version of Drools used ?
(In reply to comment #1) > Max Rydahl Andersen <max.andersen> made a comment on jira > JBIDE-11033 > > doesn't this depend on the version of Drools used ? The "#" has been deprecated for a very long time, or so I'm told. It'd be great if the tooling used some more-universal form of commenting code.
Fixed and back-ported to 5.3.x. I also fixed the same issue for RuleFlow Script Tasks that allow Globals and Imports to be defined (create a RuleFlow, add a Script Task, view properties, select Action and check Imports... and Globals...).
Michael Anstis <michael.anstis> updated the status of jira GUVNOR-1868 to Resolved
Michael Anstis <michael.anstis> updated the status of jira JBRULES-3455 to Resolved
Please note. I have not back-ported the other fixes I made to the DRL generated from within Guvnor (see referenced JIRA GUVNOR-1868) or Drools Expert Templates (see referenced JIRA JBRULES-3455). If you would like them to be back-ported please let me know :)
Kris Verlaenen <kris.verlaenen> updated the status of jira JBIDE-11033 to Resolved
Kris Verlaenen <kris.verlaenen> made a comment on jira JBIDE-11033 Fix applied in latest version
Additional changes mentioned in comment #6 have been back-ported to 5.3.
mantis, just so i'm clear what back-ported means here - is it committed to the community 5.3 branch so it would actually get picked up in a respin for JBDS 4 or are we just talking trunk here as Kris seems to be referring ?
Max Rydahl Andersen <max.andersen> updated the status of jira JBIDE-11033 to Reopened
Max Rydahl Andersen <max.andersen> made a comment on jira JBIDE-11033 Kris - which version is this for ? you removed the fix version so not possible to trace it anymore.
(In reply to comment #10) > mantis, just so i'm clear what back-ported means here - is it committed to the > community 5.3 branch so it would actually get picked up in a respin for JBDS 4 > or are we just talking trunk here as Kris seems to be referring ? Hi Max, the fix has been applied to the 5.3 branch too, so it should be in the next JBDS release (assuming it is taken from the 5.3 branch). Thanks, Mike
Kris Verlaenen <kris.verlaenen> made a comment on jira JBIDE-11033 Max, This is issue has been resolved in the latest community branch and the latest product branch. So whenever a new update for droolsjbpm tooling is made (from either of these branches), the fix will be included. Usually I keep the issues open until a new version has been integrated, after which the issue is closed, with the correct fix version. So let's keep this issue open until it has been verified. Kris
Max Rydahl Andersen <max.andersen> made a comment on jira JBIDE-11033 putting on soa fix version so not showing up as unassigned.
Update status to ON_QA. Please verify them against ER6.
fyi, there is no need to tie this to QE of a specific runtime ER6 release. This is pure tooling side issue and there is no such thing as an ER6 tooling release afaik.
There are wider ramifications. See comment #6. Guvnor also generated DRL containing the deprecated # symbol. So.... there's some Guvnor testing and some Tooling (Eclipse) testing that is needed.
Not fixed in BRMS 5.3.0 ER6. Cannot verify since provided plugin file jbosstools-drools-5.3_trunk-Update-SNAPSHOT.zip from here http://jawa05.englab.brq.redhat.com/candidate/BRMS-5.3.0-ER6/jbosstools/ has old date and was not updated. Ryan, please provide us with the latest snapshot of the Drools Eclipse plugin for testing. Update also old md5 checksum file.
The plugins should be provided by Doug Palmer when he is doing the SOA/BRMS plugin builds. Tooling is not supposed to be part of specific runtime build.
Confirmed with Doug. This fix for this issue would be included in next release.(it's not in 5.0.0-beta1, it will be in beta2). Re-assign to Doug. Thanks Max for clarification, I would not include the plugin for next platform release.
Doug, is this available for testing?
(In reply to comment #26) > Doug, is this available for testing? Yes, it should be available in the Beta2 soa tools release.
Cool, moving to ON_QA.
This is not fixed. Steps to reproduce: 1) New Rule Resource 2) Check "Use Functions" (otherwise fill out the form as usual) 3) Find the following code be generated: function myFunction( ... ) { #function content (can have multiple functions) }
https://github.com/droolsjbpm/droolsjbpm-tools/commit/26d685e97be74bd1574cd464e55b8184be494790
Douglas Palmer <dpalmer> updated the status of jira JBIDE-11033 to Resolved
Len DiMaggio <ldimaggi> updated the status of jira JBIDE-11033 to Closed
Len DiMaggio <ldimaggi> made a comment on jira JBIDE-11033 Verified fixed in SOA - http://www.qa.jboss.com/binaries/RHDS/updates/development/5.0.0.Beta3.soa-tooling/
This issue's fixes have been picked by ER9. Please verify them on ER9.
sorry, I just came across this is a tools bug. It would be availble with next SOA tooling release. Revert the target milestone fields.
Link to: JBIDE-11033
Verified fixed in SOA - http://www.qa.jboss.com/binaries/RHDS/updates/development/5.0.0.Beta3.soa-tooling/