Spec URL: http://spot.fedorapeople.org/memchan.spec SRPM URL: http://spot.fedorapeople.org/memchan-2.3-1.fc16.src.rpm Koji Rawhide Scratch Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3813496 Description: Memchan is an extension library to the script language Tcl, as created by John Ousterhout. It provides several new channel types for in-memory channels and the appropriate commands for their creation. Reviewer Note: This package was previously in Fedora, but was orphaned, then retired. It has been cleaned up and updated to the latest version. This package will resolve broken dependencies in Fedora.
I'll have a peek.
Good: - rpmlint checks return: memchan.src: W: invalid-url Source0: http://downloads.sourceforge.net/sourceforge/memchan/Memchan2.3.tar.gz <urlopen error timed out> The value should be a valid, public HTTP, HTTPS, or FTP URL. Likely an artifact of my internet connection. Verify but probably fine. memchan.x86_64: W: manual-page-warning /usr/share/man/mann/memchan.n.gz 7: warning: macro `BS' not defined This man page may contain problems that can cause it not to be formatted as intended. memchan.x86_64: W: manual-page-warning /usr/share/man/mann/memchan.n.gz 17: warning: macro `BE' not defined This man page may contain problems that can cause it not to be formatted as intended. memchan.x86_64: W: manual-page-warning /usr/share/man/mann/zero.n.gz 7: warning: macro `BS' not defined This man page may contain problems that can cause it not to be formatted as intended. memchan.x86_64: W: manual-page-warning /usr/share/man/mann/zero.n.gz 17: warning: macro `BE' not defined This man page may contain problems that can cause it not to be formatted as intended. memchan.x86_64: W: manual-page-warning /usr/share/man/mann/fifo.n.gz 7: warning: macro `BS' not defined This man page may contain problems that can cause it not to be formatted as intended. memchan.x86_64: W: manual-page-warning /usr/share/man/mann/fifo.n.gz 17: warning: macro `BE' not defined This man page may contain problems that can cause it not to be formatted as intended. memchan.x86_64: W: manual-page-warning /usr/share/man/mann/fifo2.n.gz 7: warning: macro `BS' not defined This man page may contain problems that can cause it not to be formatted as intended. memchan.x86_64: W: manual-page-warning /usr/share/man/mann/fifo2.n.gz 17: warning: macro `BE' not defined This man page may contain problems that can cause it not to be formatted as intended. memchan.x86_64: W: manual-page-warning /usr/share/man/mann/null.n.gz 7: warning: macro `BS' not defined This man page may contain problems that can cause it not to be formatted as intended. memchan.x86_64: W: manual-page-warning /usr/share/man/mann/null.n.gz 17: warning: macro `BE' not defined This man page may contain problems that can cause it not to be formatted as intended. memchan.x86_64: W: manual-page-warning /usr/share/man/mann/memchanapi.n.gz 7: warning: macro `BS' not defined This man page may contain problems that can cause it not to be formatted as intended. memchan.x86_64: W: manual-page-warning /usr/share/man/mann/memchanapi.n.gz 27: warning: macro `BE' not defined This man page may contain problems that can cause it not to be formatted as intended. Not seen these before, but not a blocker. memchan-devel.x86_64: W: no-documentation The package contains no documentation (README, doc, etc). You have to include documentation files. There's just not much there, this is ok. - package meets naming guidelines - package meets packaging guidelines - license ( MIT and Public Domain) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream - package compiles on devel (x86_64) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file - devel package ok - no .la files XXXX post/postun ldconfig ok This is not done. Is it needed for Tcl solibs? - devel requires base package n-v-r Otherwise, nothing out of order, as expected.
I don't think ldconfig is needed for the Tcl solibs, they're not in the standard ld.so pathing, and they work without ld.so.conf.
Cool. Then APPROVED.
(In reply to comment #2) > memchan.src: W: invalid-url Source0: > http://downloads.sourceforge.net/sourceforge/memchan/Memchan2.3.tar.gz <urlopen > error timed out> > The value should be a valid, public HTTP, HTTPS, or FTP URL. > > Likely an artifact of my internet connection. Verify but probably fine. It's got one too many "sourceforge"s in it. This URL works: http://downloads.sourceforge.net/memchan/Memchan2.3.tar.gz
That's funny, not only that I missed that (long day) but that it worked when I tried it. :)
Package Change Request ====================== Package Name: memchan New Branches: f17 Owners: spot InitialCC:
Git done (by process-git-requests). devel, f16 and f15 unretired, take ownership.
memchan-2.3-1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/memchan-2.3-1.fc17
memchan-2.3-1.fc17 has been pushed to the Fedora 17 testing repository.
memchan-2.3-1.fc17 has been pushed to the Fedora 17 stable repository.