Spec URL: http://jjames.fedorapeople.org/permlib/permlib.spec SRPM URL: http://jjames.fedorapeople.org/permlib/permlib-0.2.5-1.fc16.src.rpm Description: PermLib is a callable C++ library for permutation computations. Currently it supports set stabilizer and in-orbit computations, based on bases and strong generating sets (BSGS). Additionally, it computes automorphisms of symmetric matrices and finds the lexicographically smallest set in an orbit of sets. This package is a prerequisite of polymake.
I have updated the package to version 0.2.6. New URLs: Spec URL: http://jjames.fedorapeople.org/permlib/permlib.spec SRPM URL: http://jjames.fedorapeople.org/permlib/permlib-0.2.6-1.fc16.src.rpm
Same issue of the vinci package missing a Group tag. Probably should add a comment to tell from where comes the permlib-Doxyfile file. Other than that, I find it funny that something that calls itself a library is noarch and does not install any binaries :-)
(In reply to comment #2) > Same issue of the vinci package missing a Group tag. > Probably should add a comment to tell from where comes > the permlib-Doxyfile file. Okay, I will add such a comment. > Other than that, I find it funny that something that > calls itself a library is noarch and does not install > any binaries :-) Heh. Yes, fflas-ffpack is another. Both just install a bunch of headers. All the code is inlined into the client.
I'll review this one.
Waiting on the information for permlib-Doxyfile.
Oh, for heaven's sake. I fixed that 3 days ago, then didn't upload it. Must be senility setting in. Try this: Spec URL: http://jjames.fedorapeople.org/permlib/permlib.spec SRPM URL: http://jjames.fedorapeople.org/permlib/permlib-0.2.6-2.fc16.src.rpm
APPROVED Package Review ============== Key: - = N/A x = Pass ! = Fail ? = Not evaluated ==== C/C++ ==== [x]: MUST Header files in -devel subpackage, if present. [x]: MUST Package does not contain any libtool archives (.la) [x]: MUST Package does not contain kernel modules. [x]: MUST Package contains no static executables. [x]: MUST Rpath absent or only used for internal libs. [x]: MUST Package is not relocatable. ==== Generic ==== [x]: MUST Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: MUST Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: MUST %build honors applicable compiler flags or justifies otherwise. [x]: MUST All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: MUST Buildroot is not present Note: Unless packager wants to package for EPEL5 this is fine [x]: MUST Package contains no bundled libraries. [x]: MUST Changelog in prescribed format. [x]: MUST Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: Clean would be needed if support for EPEL is required [x]: MUST Sources contain only permissible code or content. [x]: MUST Each %files section contains %defattr if rpm < 4.4 Note: Note: defattr macros not found. They would be needed for EPEL5 [x]: MUST Macros in Summary, %description expandable at SRPM build time. [x]: MUST Package requires other packages for directories it uses. [x]: MUST Package uses nothing in %doc for runtime. [x]: MUST Package is not known to require ExcludeArch. [x]: MUST Permissions on files are set properly. [x]: MUST Package does not contain duplicates in %files. [x]: MUST Fully versioned dependency in subpackages, if present. [x]: MUST Spec file lacks Packager, Vendor, PreReq tags. [x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf would be needed if support for EPEL5 is required [x]: MUST Large documentation files are in a -doc subpackage, if required. [x]: MUST If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: MUST License field in the package spec file matches the actual license. Note: Licenses found: "*No copyright* UNKNOWN", "BSD (3 clause) " For detailed output of licensecheck see file: /home/threebean/reviews/797312/licensecheck.txt [x]: MUST License file installed when any subpackage combination is installed. [x]: MUST Package consistently uses macros (instead of hard-coded directory names). [x]: MUST Package is named according to the Package Naming Guidelines. [x]: MUST Package does not generate any conflict. [x]: MUST Package obeys FHS, except libexecdir and /usr/target. [x]: MUST Package must own all directories that it creates. [x]: MUST Package does not own files or directories owned by other packages. [x]: MUST Package installs properly. [x]: MUST Requires correct, justified where necessary. [!]: MUST Rpmlint output is silent. - <snip> These are false positives </snip> [x]: MUST Sources used to build the package match the upstream source, as provided in the spec URL. /home/threebean/reviews/797312/permlib-0.2.6.tar.gz : MD5SUM this package : 5d9018573233d53176edb4ed6d2d7f5f MD5SUM upstream package : 5d9018573233d53176edb4ed6d2d7f5f [x]: MUST Spec file is legible and written in American English. [x]: MUST Spec file name must match the spec package %{name}, in the format %{name}.spec. [-]: MUST Package contains a SysV-style init script if in need of one. [x]: MUST File names are valid UTF-8. [-]: MUST Useful -debuginfo package or justification otherwise. [x]: SHOULD Reviewer should test that the package builds in mock. [x]: SHOULD If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: SHOULD Dist tag is present. [x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q --requires). [-]: SHOULD Package functions as described. [x]: SHOULD Latest version is packaged. [x]: SHOULD Package does not include license text files separate from upstream. [x]: SHOULD SourceX is a working URL. [-]: SHOULD Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: SHOULD Package should compile and build into binary rpms on all supported architectures. [x]: SHOULD %check is present and all tests pass. [x]: SHOULD Packages should try to preserve timestamps of original installed files. [x]: SHOULD Spec use %global instead of %define. Issues: [!]: MUST Rpmlint output is silent. - <snip> These are false positives </snip> Generated by fedora-review 0.2.0git External plugins:
Thanks very much for the review, Ralph. New Package SCM Request ======================= Package Name: permlib Short Description: Library for permutation computations Owners: jjames Branches: f17 InitialCC:
Git done (by process-git-requests).
permlib-0.2.6-2.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/permlib-0.2.6-2.fc17
permlib-0.2.6-2.fc17 has been pushed to the Fedora 17 testing repository.
permlib-0.2.6-2.fc17 has been pushed to the Fedora 17 stable repository.