Red Hat Bugzilla – Bug 798681
Review Request: python-pyotp - Python One Time Password library
Last modified: 2012-03-24 15:10:37 EDT
Spec URL: http://fedorapeople.org/~icon/f/python-pyotp.spec
SRPM URL: http://fedorapeople.org/~icon/f/python-pyotp-1.3.1-1.fc16.src.rpm
A Python library for generating one time passwords according to
RFC 4226 and the HOTP RFC.
I'd be happy to review this. Look for a full review hopefully later today.
OK - Package meets naming and packaging guidelines
OK - Spec file matches base package name.
OK - Spec has consistant macro usage.
OK - Meets Packaging Guidelines.
OK - License (BSD)
OK - License field in spec matches
OK - License file included in package
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum:
OK - BuildRequires correct
OK - Package has %defattr and permissions on files is good.
See below - Package has a correct %clean section.
See below - Package has correct buildroot
OK - Package is code or permissible content.
OK - Packages %doc files don't affect runtime.
OK - Package has rm -rf RPM_BUILD_ROOT at top of %install
OK - Package compiles and builds on at least one arch.
OK - Package has no duplicate files in %files.
OK - Package doesn't own any directories other packages own.
OK - Package owns all the directories it creates.
OK - Package obey's FHS standard (except for 2 exceptions)
OK - No rpmlint output.
OK - final provides and requires are sane.
OK - Should build in mock.
OK - Should build on all supported archs
OK - Should have dist tag
OK - Should package latest version
OK - Should not use file requires outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin
1. You may need to add %clean and buildroot for EPEL branches.
They are of course not required for Fedora anymore.
2. The PKG-INFO says:
Might ask upstream to fix that.
I see no blockers here, so this package is APPROVED.
Nice! Thanks, Kevin.
New Package SCM Request
Package Name: python-pyotp
Short Description: A Python library for generating one time passwords
Branches: f16, f17, el5, el6
Git done (by process-git-requests).
python-pyotp-1.3.1-1.el6 has been submitted as an update for Fedora EPEL 6.
python-pyotp-1.3.1-1.fc16 has been submitted as an update for Fedora 16.
python-pyotp-1.3.1-1.fc17 has been submitted as an update for Fedora 17.
python-pyotp-1.3.1-1.fc17 has been pushed to the Fedora 17 testing repository.
python-pyotp-1.3.1-1.fc17 has been pushed to the Fedora 17 stable repository.
python-pyotp-1.3.1-1.fc16 has been pushed to the Fedora 16 stable repository.
python-pyotp-1.3.1-1.el6 has been pushed to the Fedora EPEL 6 stable repository.