Bugzilla will be upgraded to version 5.0. The upgrade date is tentatively scheduled for 2 December 2018, pending final testing and feedback.
Bug 798938 - Snapshot-revert will report error with startupPolicy='requisite' when floppy/cdrom disk is missing
Snapshot-revert will report error with startupPolicy='requisite' when floppy/...
Status: CLOSED ERRATA
Product: Red Hat Enterprise Linux 6
Classification: Red Hat
Component: libvirt (Show other bugs)
6.3
x86_64 Linux
medium Severity high
: rc
: ---
Assigned To: Michal Privoznik
Virtualization Bugs
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2012-03-01 05:39 EST by weizhang
Modified: 2012-06-20 02:49 EDT (History)
7 users (show)

See Also:
Fixed In Version: libvirt-0.9.10-6.el6
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2012-06-20 02:49:21 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)
domain xml (2.88 KB, text/plain)
2012-03-14 04:41 EDT, weizhang
no flags Details
libvirtd.log (729.22 KB, text/plain)
2012-03-14 04:44 EDT, weizhang
no flags Details


External Trackers
Tracker ID Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2012:0748 normal SHIPPED_LIVE Low: libvirt security, bug fix, and enhancement update 2012-06-19 15:31:38 EDT

  None (edit)
Description weizhang 2012-03-01 05:39:54 EST
Description of problem:
When floppy/cdrom image is missing, snapshot-revert will report error even if with startupPolicy='requisite' 

Also the error message is ambiguous "Unknown error 512" and need to be improved

Version-Release number of selected component (if applicable):
qemu-kvm-0.12.1.2-2.232.el6.x86_64
kernel-2.6.32-225.el6.x86_64
libvirt-0.9.10-3.el6.x86_64

How reproducible:
100%

Steps to Reproduce:
1.Start a guest with qcow2 type disk image and a floppy disk like
    <disk type='file' device='floppy'>
      <driver name='qemu' type='raw' cache='none'/>
      <source file='/var/lib/libvirt/images/floppy.img' startupPolicy='requisite'/>
      <target dev='fda' bus='fdc'/>
    </disk>

2.Create snapshot of running guest 
# virsh snapshot-create guest

3.Destroy the guest and remove image /var/lib/libvirt/images/floppy.img

4.Revert to running snapshot
# virsh snapshot-revert [snapshot name]
  
Actual results:
report error:
error: cannot access file '/var/lib/libvirt/images/floppy.img': Unknown error 512

Expected results:
should revert successfully

Additional info:
Comment 2 Michal Privoznik 2012-03-07 13:20:37 EST
Patch proposed upstream:

https://www.redhat.com/archives/libvir-list/2012-March/msg00301.html
Comment 3 Michal Privoznik 2012-03-08 05:53:11 EST
Another patch proposed upstream (for that weird error message):

https://www.redhat.com/archives/libvir-list/2012-March/msg00324.html
Comment 8 weizhang 2012-03-14 03:47:57 EDT
Test failed on
kernel-2.6.32-250.el6.x86_64
libvirt-0.9.10-5.el6.x86_64
qemu-kvm-0.12.1.2-2.246.el6.x86_64

After revert, it will report error
virsh snapshot-revert qcow2 1331711016
error: cannot access file '/var/lib/libvirt/images/floppy.img': No such file or directory

So reassign it
Comment 9 weizhang 2012-03-14 04:41:26 EDT
Created attachment 569916 [details]
domain xml
Comment 10 weizhang 2012-03-14 04:44:22 EDT
Created attachment 569918 [details]
libvirtd.log
Comment 12 weizhang 2012-03-19 04:51:23 EDT
verify pass on
kernel-2.6.32-250.el6.x86_64
qemu-kvm-0.12.1.2-2.246.el6.x86_64
libvirt-0.9.10-6.el6.x86_64

The snapshot-revert succeeds without error after remove floppy/cdrom image with startupPolicy='requisite'
Comment 14 errata-xmlrpc 2012-06-20 02:49:21 EDT
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHSA-2012-0748.html

Note You need to log in before you can comment on or make changes to this bug.