Hide Forgot
Description of problem: rhc-outage prints success during syncing even when a failure occurred. This seems to be because the response object isn't checked in the following code. http_req(:get, "#{url}/sync/#{hostname}") do |resp| puts "\tSuccess" end The sync here actually failed with "<h1>Internal Server Error</h1>", yet shows success. [root@ex-srv1 status]# ./rhc-outage sync Syncing https://ex-srv1.stg.rhcloud.com/app/status Success Success Syncing https://ex-srv2.stg.rhcloud.com/app/status Success Success [root@ex-srv1 status]# Version-Release number of selected component (if applicable): rhc-site-0.87.16-1.el6_2.noarch How reproducible: 100% Steps to Reproduce: 1. Have a failure case 2. Try to sync 3. Notice it failed yet it says success. Actual results: says success even when it failed Expected results: should tell the failure (as much info as possible)
Fixed in commit: b0260811edc66f3540d38fd0e01281afb9f0bd30
Sorry, wrong commit id. Correct one should be: ec3959a859a6c149215a1abcbb027160f1085013
Move it to ON_QA,since the fix is included in the latest build.
Verify this bug by setting an invalid host ip in hosts.yml file and run ./rhc-outage new issue1 "it's not a good network", it will fail with errors: Syncing https://10.1.2.3/app/status Failed: Server responded with Server not running Syncing https://10.2.3.4/app/status Failed: Server responded with Server not running BTW,the returned exit code is still "0" even if it failed ,but since it's not an user end command and admin may not care about the exit code,it could be accepted,I'll move it to verified , if any of you think it needs to be fixed, feel free to re-open it.