Bug 799693 - guestfs.h failes to compile with c++ compiler
guestfs.h failes to compile with c++ compiler
Status: CLOSED UPSTREAM
Product: Virtualization Tools
Classification: Community
Component: libguestfs (Show other bugs)
unspecified
Unspecified Linux
unspecified Severity unspecified
: ---
: ---
Assigned To: Richard W.M. Jones
:
Depends On:
Blocks: 799695
  Show dependency treegraph
 
Reported: 2012-03-04 06:28 EST by Marcin Gibula
Modified: 2012-03-04 06:59 EST (History)
2 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 799695 (view as bug list)
Environment:
Last Closed: 2012-03-04 06:59:07 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)
Proposed patch. (1.97 KB, patch)
2012-03-04 06:28 EST, Marcin Gibula
no flags Details | Diff

  None (edit)
Description Marcin Gibula 2012-03-04 06:28:40 EST
Created attachment 567384 [details]
Proposed patch.

Description of problem:
Function guestfs_mkdtemp uses c++ keyword "template" as a parameter name. In result, attempt to use guestfs.h header in c++ program results in compile error.

Version-Release number of selected component (if applicable):
1.16.7

How reproducible:

#include <guestfs.h>

int main()
{
}


Steps to Reproduce:
1. Try to compile above with g++
  
Actual results:
/usr/include/guestfs.h:1401:76: error: expected ‘,’ or ‘...’ before ‘template’

Expected results:
No error.

Additional info:
Proposed patch included.
Comment 1 Richard W.M. Jones 2012-03-04 06:50:55 EST
Thanks, the patch looks good and I will push it shortly.
Comment 2 Richard W.M. Jones 2012-03-04 06:59:07 EST
Upstream commit:
49611f121fa10d1497e46ab9aa6a7448cb89cd86

Will be fixed in 1.17.11 / 1.16.8.

Note You need to log in before you can comment on or make changes to this bug.