Bug 800086 - Bugs found in pyOpenSSL-0.12-2.fc17 using gcc-with-cpychecker static analyzer
Bugs found in pyOpenSSL-0.12-2.fc17 using gcc-with-cpychecker static analyzer
Product: Fedora
Classification: Fedora
Component: pyOpenSSL (Show other bugs)
Unspecified Unspecified
unspecified Severity unspecified
: ---
: ---
Assigned To: Tomas Mraz
Fedora Extras Quality Assurance
Depends On:
Blocks: cpychecker
  Show dependency treegraph
Reported: 2012-03-05 12:47 EST by Dave Malcolm
Modified: 2013-04-04 08:42 EDT (History)
1 user (show)

See Also:
Fixed In Version: pyOpenSSL-0.13-6.fc20
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2013-04-04 08:42:51 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---

Attachments (Terms of Use)

  None (edit)
Description Dave Malcolm 2012-03-05 12:47:34 EST
Description of problem:
I've been writing an experimental static analysis tool to detect bugs commonly occurring within C Python extension modules:

I ran the latest version of the tool (in git master; post 0.9) on
pyOpenSSL-0.12-2.fc17.src.rpm, and it reports various errors.

You can see a list of errors here, triaged into categories (from most significant to least significant):

I've manually reviewed the issues reported by the tool.

Within the category "Reference leaks" the 1 issue reported seems to be a genuine memory leak when OpenSSL/crypto/crypto.c:global_passphrase_callback receives an object that isn't of the bytes type.

Within the category "Reference count too low within an initialization routine" the 1 issue reported appears to be inconsequential.

Within the category "Segfaults within error-handling paths" the 1 issue reported appears to be a genuine crasher that could occur under low-memory conditions; it needs an:
   if (argv == NULL) {
       return NULL;
or similar.

Within the category "Returning (PyObject*)NULL without setting an exception" the 12 issues reported appear to all be false positives: the checker doesn't know that exception_from_error_queue(crypto_Error) presumably sets the thread's exception state.

There may of course be other bugs in my checker tool.

Hope this is helpful; let me know if you need help reading the logs that the tool generates - I know that it could use some improvement.

Version-Release number of selected component (if applicable):
gcc-python-plugin post-0.9 git 11462291a66c8db693c8884cb84b795bb5988ffb running the checker in an *f16* chroot
Comment 1 Fedora End Of Life 2013-04-03 13:53:19 EDT
This bug appears to have been reported against 'rawhide' during the Fedora 19 development cycle.
Changing version to '19'.

(As we did not run this process for some time, it could affect also pre-Fedora 19 development
cycle bugs. We are very sorry. It will help us with cleanup during Fedora 19 End Of Life. Thank you.)

More information and reason for this action is here:

Note You need to log in before you can comment on or make changes to this bug.