Red Hat Bugzilla – Bug 800113
2 memory leaks found in error-handling paths in pygoocanvas-0.14.1-6.fc17 using gcc-with-cpychecker static analyzer
Last modified: 2015-02-18 08:41:42 EST
Description of problem:
I've been writing an experimental static analysis tool to detect bugs commonly occurring within C Python extension modules:
I ran the latest version of the tool (in git master; post 0.9) on
pygoocanvas-0.14.1-6.fc17.src.rpm, and it reports various errors.
You can see a list of errors here, triaged into categories (from most significant to least significant):
I've manually reviewed the issues reported by the tool.
Within the category "Reference leaks" the 2 issues reported appear to be genuine memory leaks in error-handling paths: the error-handling clauses need a Py_DECREF(tuple)
Within the category "Segfaults within error-handling paths" the 3 issues reported appear to be genuine crashers where an allocation fails and returns NULL; however, given that GLib aborts the process when an allocation fails, this may be already be a lost cause.
Within the category "Possible reference leaks" the first 2 of the 3 issues reported appear to be false positives, which I've filed as https://fedorahosted.org/gcc-python-plugin/ticket/36 ; the third issue is inconsequential.
Within the category "Returning (PyObject*)NULL without setting an exception" the 11 issues reported appear to be false positives.
There may of course be other bugs in my checker tool.
Hope this is helpful; let me know if you need help reading the logs that the tool generates - I know that it could use some improvement.
Version-Release number of selected component (if applicable):
gcc-python-plugin post-0.9 git 11462291a66c8db693c8884cb84b795bb5988ffb running the checker in an *f16* chroot
(In reply to comment #0)
> Hope this is helpful; let me know if you need help reading the logs that the
> tool generates - I know that it could use some improvement.
It's always good to have someone jump in and do detailed analysis like this. However, fundamental flaws like this should definitely be reported upstream (https://bugzilla.gnome.org/enter_bug.cgi?product=goocanvas) by the person who discovered the flaw. I hope you'll take the time to do this as it takes out the middleman.
(In reply to comment #1)
> (In reply to comment #0)
> > Hope this is helpful; let me know if you need help reading the logs that the
> > tool generates - I know that it could use some improvement.
> It's always good to have someone jump in and do detailed analysis like this.
> However, fundamental flaws like this should definitely be reported upstream
> (https://bugzilla.gnome.org/enter_bug.cgi?product=goocanvas) by the person who
> discovered the flaw. I hope you'll take the time to do this as it takes out
> the middleman.
Thanks; I've filed this upstream as:
(against "pygoocanvas" rather than "goocanvas")
This bug appears to have been reported against 'rawhide' during the Fedora 19 development cycle.
Changing version to '19'.
(As we did not run this process for some time, it could affect also pre-Fedora 19 development
cycle bugs. We are very sorry. It will help us with cleanup during Fedora 19 End Of Life. Thank you.)
More information and reason for this action is here:
This message is a notice that Fedora 19 is now at end of life. Fedora
has stopped maintaining and issuing updates for Fedora 19. It is
Fedora's policy to close all bug reports from releases that are no
longer maintained. Approximately 4 (four) weeks from now this bug will
be closed as EOL if it remains open with a Fedora 'version' of '19'.
Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version'
to a later Fedora version.
Thank you for reporting this issue and we are sorry that we were not
able to fix it before Fedora 19 is end of life. If you would still like
to see this bug fixed and are able to reproduce it against a later version
of Fedora, you are encouraged change the 'version' to a later Fedora
version prior this bug is closed as described in the policy above.
Although we aim to fix as many bugs as possible during every release's
lifetime, sometimes those efforts are overtaken by events. Often a
more recent Fedora release includes newer upstream software that fixes
bugs or makes them obsolete.
Fedora 19 changed to end-of-life (EOL) status on 2015-01-06. Fedora 19 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.
If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
Thank you for reporting this bug and we are sorry it could not be fixed.