Bug 800143 - Bug found in python-cups-1.9.60-1.fc17 using gcc-with-cpychecker static analyzer
Summary: Bug found in python-cups-1.9.60-1.fc17 using gcc-with-cpychecker static analyzer
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: python-cups
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Tim Waugh
QA Contact: Fedora Extras Quality Assurance
URL: http://fedorapeople.org/~dmalcolm/gcc...
Whiteboard:
Depends On:
Blocks: cpychecker
TreeView+ depends on / blocked
 
Reported: 2012-03-05 20:15 UTC by Dave Malcolm
Modified: 2012-03-13 18:34 UTC (History)
2 users (show)

Fixed In Version: python-cups-1.9.61-1.fc17
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-03-13 18:34:40 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Dave Malcolm 2012-03-05 20:15:44 UTC
Description of problem:
I've been writing an experimental static analysis tool to detect bugs commonly occurring within C Python extension modules:
  https://fedorahosted.org/gcc-python-plugin/
  http://gcc-python-plugin.readthedocs.org/en/latest/cpychecker.html
  http://fedoraproject.org/wiki/Features/StaticAnalysisOfPythonRefcounts

I ran the latest version of the tool (in git master; post 0.9) on
python-cups-1.9.60-1.fc17.src.rpm, and it reports various errors.

You can see a list of errors here, triaged into categories (from most significant to least significant):
http://fedorapeople.org/~dmalcolm/gcc-python-plugin/2012-03-05/python-cups-1.9.60-1.fc17/

I've manually reviewed the issue reported by the tool.

Within the category "Reference count too low" the 1 issue reported:
cupsmodule.c:cups_require:ob_refcnt of return value is 1 too low
appears to be a genuine problem: the:
   return Py_None;
should be a
   Py_RETURN_NONE;
otherwise every call to cups_require() will leak a reference to the Py_None singleton.

There may of course be other bugs in my checker tool.

Hope this is helpful; let me know if you need help reading the logs that the tool generates - I know that it could use some improvement.

Version-Release number of selected component (if applicable):
python-cups-1.9.60-1.fc17
gcc-python-plugin post-0.9 git 11462291a66c8db693c8884cb84b795bb5988ffb running the checker in an *f16* chroot

Comment 1 Fedora Update System 2012-03-06 12:00:17 UTC
python-cups-1.9.61-1.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/python-cups-1.9.61-1.fc17

Comment 2 Fedora Update System 2012-03-07 07:21:55 UTC
Package python-cups-1.9.61-1.fc17:
* should fix your issue,
* was pushed to the Fedora 17 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing python-cups-1.9.61-1.fc17'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2012-3176/python-cups-1.9.61-1.fc17
then log in and leave karma (feedback).

Comment 3 Fedora Update System 2012-03-13 18:34:40 UTC
python-cups-1.9.61-1.fc17 has been pushed to the Fedora 17 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.