RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 801273 - Document for set-pgroup need to be updated
Summary: Document for set-pgroup need to be updated
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 6
Classification: Red Hat
Component: libguestfs
Version: 6.2
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: rc
: ---
Assignee: Richard W.M. Jones
QA Contact: Virtualization Bugs
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-03-08 06:19 UTC by Qixiang Wan
Modified: 2012-06-20 07:01 UTC (History)
4 users (show)

Fixed In Version: libguestfs-1.16.10-1.el6
Doc Type: Bug Fix
Doc Text:
No Documentation needed
Clone Of:
Environment:
Last Closed: 2012-06-20 07:01:08 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2012:0774 0 normal SHIPPED_LIVE Low: libguestfs security, bug fix, and enhancement update 2012-06-19 19:29:50 UTC

Description Qixiang Wan 2012-03-08 06:19:03 UTC 
Description of problem:
As the document says, the default value of pgroup should be "false" because users may want to use "^C" to kill the subprocess.
But now the default value is "true".

Version-Release number of selected component (if applicable):
libguestfs-1.16.8-1.el6.x86_64

How reproducible:
100%

Steps to Reproduce:
1. [root@localhost ~]# guestfish get-pgroup
true
2. [root@localhost ~]# guestfish help set-pgroup
NAME
    set-pgroup - set process group flag

SYNOPSIS
     set-pgroup pgroup

DESCRIPTION
    If "pgroup" is true, child processes are placed into their own process
    group.

    The practical upshot of this is that signals like "SIGINT" (from users
    pressing "^C") won't be received by the child process.

    The default for this flag is false, because usually you want "^C" to
    kill the subprocess.

    You can use 'pgroup' as an alias for this command.

  
Actual results:
$ guestfish get-pgroup
true

Expected results:
$ guestfish get-pgroup
false

Additional info:
Comment 1 Richard W.M. Jones 2012-03-08 10:24:21 UTC 
guestfish sets pgroup to true on its own handle, when used
interactively:

https://github.com/libguestfs/libguestfs/blob/4504f424f5589f81086f5250674b55708e162e5f/fish/fish.c#L399

If you access the libguestfs API directly then you'll see
it starts off as false:

$ perl -MSys::Guestfs -e 'printf "%d\n", Sys::Guestfs->new()->get_pgroup()'
0

Probably we just need to clarify the documentation.
Comment 2 Qixiang Wan 2012-03-08 10:54:59 UTC 
(In reply to comment #1)
> 
> Probably we just need to clarify the documentation.

That sounds reasonable. Changing the bug subject.
Comment 3 Richard W.M. Jones 2012-03-08 17:43:40 UTC 
Fixed upstream:

https://github.com/libguestfs/libguestfs/commit/0721464b83915fbfae6d6a9da787f5069b2c6d6a
Comment 6 Qixiang Wan 2012-03-15 03:15:49 UTC 
Verified with libguestfs-1.16.10-1.el6.

The current document for set-pgroup:

><fs> help set-pgroup
NAME
    set-pgroup - set process group flag

SYNOPSIS
     set-pgroup pgroup

DESCRIPTION
    If "pgroup" is true, child processes are placed into their own process
    group.

    The practical upshot of this is that signals like "SIGINT" (from users
    pressing "^C") won't be received by the child process.

    The default for this flag is false, because usually you want "^C" to
    kill the subprocess. Guestfish sets this flag to true when used
    interactively, so that "^C" can cancel long-running commands gracefully
    (see "user_cancel").

    You can use 'pgroup' as an alias for this command.
Comment 7 Richard W.M. Jones 2012-04-26 12:23:49 UTC 
    Technical note added. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    New Contents:
No Documentation needed
Comment 9 errata-xmlrpc 2012-06-20 07:01:08 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHSA-2012-0774.html
Note You need to log in before you can comment on or make changes to this bug.