Bug 801869 - Disable community based service repository in designer
Summary: Disable community based service repository in designer
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: JBoss Enterprise BRMS Platform 5
Classification: JBoss
Component: BRM (Guvnor)
Version: BRMS 5.3.0.GA
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ER7
: BRMS 5.3.0.GA
Assignee: lcarlon
QA Contact: Petr Široký
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-03-09 17:18 UTC by Jiri Locker
Modified: 2013-04-30 03:22 UTC (History)
7 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-06-25 02:53:55 UTC
Type: Bug


Attachments (Terms of Use)

Description Jiri Locker 2012-03-09 17:18:45 UTC
Description of problem:
Currently, the service repository location for designer is configured to

> http://people.redhat.com/kverlaen/repository

This cannot be supported as part of the product. The service repository is an alternative to storing work item definitions in Gunvor and can be completely excluded for the product.

If it is not excluded, the best solution, in my opinion, is to have it disabled by default and provide a thorough documentation on how to setup a local customer-defined repository and how to configure designer to connect to it.

Version-Release number of selected component (if applicable):
ER4

Comment 1 Tihomir Surdilovic 2012-03-09 17:29:09 UTC
What are we doing in the Eclipse editor because it's connecting to the same URL as Designer. I don't really see the point of disabling all these services.

Comment 2 Tihomir Surdilovic 2012-03-09 17:33:36 UTC
In Eclipse we don't remove functionality that is specific - we document it. In Guvnor we don't disable functionality, we document it..for Designer it seems different :) I would rather add ability for users to enter in a URL to their own repository than disabling this functionality by default, because:

1) noone reads the documentation - thus this functionality will be missed by customers
2) We cannot really support custom service nodes for any customer so why not just document we cannot support custom service node implementations but allow users to use this important feature, rather than disabling it.

Comment 5 Prakash Aradhya 2012-03-12 14:06:35 UTC
Tiho:
Can you help Lee document this accordingly ?
Essentially what needs to go in documentation is to help people understand what this is used for and steps to create their own repository and point the designer to that repo.
With that it is OK to keep the functionality without disabling it.

Comment 6 Tihomir Surdilovic 2012-03-29 16:57:49 UTC
It's possible to disable this feature in designer now. In $designer-war/profiles/jbpm.xml comment the following line (8):

<plugin name="ORYX.Plugins.ServiceRepoIntegration"/>

Comment 7 Ryan Zhang 2012-04-23 07:40:09 UTC
Update status to ON_QA. Please verify them against ER6.

Comment 9 Petr Široký 2012-05-02 15:43:23 UTC
Verified in 5.3.0 ER6 that the service repository can be disabled by commenting the '<plugin name="ORYX.Plugins.ServiceRepoIntegration"/>' as Tiho mentioned. 

By default the repository is currently enabled, but I think it should be disabled (in product build, not in project itself) as it is just example. Documentation should contain information about how to create and setup own repository (as Prakash said).

Comment 10 Ryan Zhang 2012-05-09 10:53:38 UTC
This is done in platform side.
Both the pluin and the servicerepository setting have both been disabled.

Re-assign to Lee for documentation updates.
hi, Lee
The steps to enable the function/ability to connect  service repository is to change  the two lines in in
brms-standalone-5.3.0/jboss-as/server/${conf}/deploy/designer.war/profiles/jbpm.xml
Change 
<!--plugin name="ORYX.Plugins.ServiceRepoIntegration"/-->
to
<plugin name="ORYX.Plugins.ServiceRepoIntegration"/>

Change 
<!--servicerepository location="http://people.redhat.com/kverlaen/repository"/--> 
to
<servicerepository location="http://people.redhat.com/kverlaen/repository"/>

and restart the server. 
The function/tool button should be present in the process-designer toolbar.
The connected repository is http://people.redhat.com/kverlaen/repository

Comment 14 Tihomir Surdilovic 2012-05-11 14:19:09 UTC
We need to re-open this issue and NOT disable the service repository plugin any more. Per Prakash's request we have changed the code to no longer connect (or have any references) to the community repository and users have to enter in an URL and connect manually by clicking a Connect button. 

Thanks.

Comment 15 Tihomir Surdilovic 2012-05-11 14:52:20 UTC
The new implementation is different as in the users are forced to enter in an URL of the service repository. Before it was automatically connecting to our community jBPM repo. After entering an URL, users click on the "Connect" button to connect to their service repo and can install service nodes just as before.

Comment 16 Ryan Zhang 2012-05-11 15:02:13 UTC
yep, Tihomir has informed me that he has given a better solution to this issue.
He has updated the service repo plugin which would not connect to the community repo and user would be able to enter an URL to connect the service repo.

So it make more sense for platform side to not comment/disable the service repo plugin.

Lukas, do you also think it's a better option? 
Lee it might also needs updates in the related part in doc.

But I think this would also require to request the block+ flag.

Comment 17 Julian Coleman 2012-05-11 16:05:25 UTC
Service uncommented in revision 11044 of:

  src/main/patches/processdesigner/patch_designer_conf.xml

Commit message:

  Remove BZ 801869 patch.
  Update checksum.

Comment 18 Ryan Zhang 2012-05-14 08:16:54 UTC
The fixed for this issue should be included in ER7. Please do verification on it.

Comment 19 Petr Široký 2012-05-21 16:36:38 UTC
Verified fixed in 5.3.0 ER7.

Comment 20 lcarlon 2012-05-30 02:56:31 UTC
Documentation updated, details added to BZ805373.


Note You need to log in before you can comment on or make changes to this bug.