Description of problem: Return and delete after delete an app should not cause exception. Version-Release number of selected component (if applicable): devenv_stage_144 How reproducible:always Steps to Reproduce: 1.Go to openshift website and login 2.Create an app and delete this app 3.Click return of the browser and click the delete button on the page again Actual results: It will cause the following error: ActiveResource::ResourceNotFound in ApplicationsController#destroy Failed. Response code = 404. Response message = Not Found. Rails.root: /var/www/stickshift/site Application Trace | Framework Trace | Full Trace app/models/rest_api/base.rb:537:in `get' app/models/rest_api/base.rb:537:in `get' app/models/rest_api/base.rb:418:in `find_single' app/models/rest_api/base.rb:283:in `find' app/models/domain.rb:31:in `find_application' app/controllers/applications_controller.rb:85:in `destroy' Expected results: There should be remind message, not exception. Additional info:
In production this should display the standard 404 page - which is what I would expect if the app was deleted (just like if i followed the link in). There's not much we can do here because the browser is caching that previous page, not us. Would a better 404 page for apps satisfy your concerns?
(In reply to comment #1) > In production this should display the standard 404 page - which is what I would > expect if the app was deleted (just like if i followed the link in). > > There's not much we can do here because the browser is caching that previous > page, not us. > > Would a better 404 page for apps satisfy your concerns? Yes, Return 404 is better than code exceptions. Thanks
Test this issue on stage, will not return 404 code exception, but error message which says "We're sorry, but something went wrong.We've been notified about this issue and we'll take a look at it shortly." Is this expected ?
Hrm, I would have expected the 404 page to show up. I'll dig into it on stage.
Probably need a generic rescue_from for ActiveResource::ResourceNotFound that sets 404 correctly.
All pages should display the generic 404 in dev mode and in production mode. Eventually we may want to revert this for debugging purposes in dev mode.
Tested this issue on stage, it will return "Page not found" message, so verify this bug.