Hide Forgot
Spec URL: http://mmckinst.fedorapeople.org/packages/pyp/pyp.spec SRPM URL: http://mmckinst.fedorapeople.org/packages/pyp/pyp-2.11-1.fc16.src.rpm Description: Pyp is a Linux command line text manipulation tool similar to awk or sed, but which uses standard python string and list methods as well as custom functions evolved to generate fast results in an intense production environment.
Hi, a few comment : - why %doc without any doc ? - you requires python, but I think you need to tell the version ( 2 or 3 ) - BuildRoot is uneeded, unless you plan to support epel 5 ( if you need to do so, there is then others stuff, like %clean section, etc ) and there is no license at all in the source code ( nor shipped as part of a tarball, since there is no tarball ), which is a blocking point : https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text
I've got a bug report with them about the licensing issue: https://code.google.com/p/pyp/issues/detail?id=9 . Once that is resolved, I'll fix the other issues you mentioned.
The license is now included in the source code. I've updated the spec to include a clean section and explicitly state it requires python2. I do intend to have it in EPEL 5 so I've specified the buildroot. I also removed the un-needed doc section. spec: http://mmckinst.fedorapeople.org/packages/pyp/pyp.spec srpm: http://mmckinst.fedorapeople.org/packages/pyp/pyp-2.12-1.fc16.src.rpm
Source0 and URL should be changed.
I've fixed the URL and Source0. Although its just one file, I now check it out from svn so its clear which version is being used. spec: http://mmckinst.fedorapeople.org/packages/pyp/pyp.spec srpm: http://mmckinst.fedorapeople.org/packages/pyp/pyp-2.12-20120402.1.fc16.src.rpm
- The 'Release' tag order should more look the example for kismet for a post-release [1][2]. - 'BuildRoot', the %clean section and the condition for el5 is only needed if you want to support EPEL5. In this case the %install section must be cleaned. [1] http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Post-Release_packages [2] http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Snapshot_packages
I've updated the release tag to follow the packaging guidelines. I do intend to have it in EPEL 5 so I've specified the buildroot. spec: http://mmckinst.fedorapeople.org/packages/pyp/pyp.spec srpm: http://mmckinst.fedorapeople.org/packages/pyp/pyp-2.12-2.20120402.fc17.src.rpm
This is just a single file, packaging it as an RPM is overkill. If someone else has interest they can take over the RPM.